Overview

Request 547090 accepted

- Update to version 1.3.1+20171130.ecbdf9c:
* Build: cluster-servant: Compile with pacemaker-2.0

- Fix: build error with glibc 2.25
- Fix: gcc format string error
- Upstream version cs: a7a7d792b9922f19bbace276c8a154e157a4f99c

- Replace references to /var/adm/fillup-templates with new
%_fillupdir macro (boo#1069468)

- Bump to 1.3.1
- Add commands to test/query watchdogs
- Upstream version cs: a74b4d25a3eb93fe1abbe6e3ebfd2b16cf48873f (v1.3.1)

- man: Call "-P" option "Pacemaker integration" in the description (bsc#1033600)
- sbd-inquisitor: Do not use watchdog if the conflicting options "-W" and "-w /dev/null" are both supplied (bsc#1047376)
* Drop bug-1047376_sbd-not-use-watchdog-conflicting-options.patch which has been merged upstream
- sbd-inquisitor: Enable pacemaker integration by default as advertised in sysconfig.sbd (bsc#1046421, bsc#1033600)
* Drop bug-1046421_sbd-enable-pacemaker-integration-by-default.patch which has been merged upstream
- sbd-inquisitor: Respect the obsolete option SBD_WATCHDOG for backward compatibility (bsc#1047372)
* Drop bug-1047372_sbd-SBD_WATCHDOG-compatibility.patch which has been merged upstream
- Upstream version cs: 681ce1acbda12754eb97fb91f9a7306ff368452f

- cluster-servant: check for corosync 2Node mode
- disk-servant: signal reset request via exit-code
- improve reboot after sysrq_trigger
- Upstream version cs: 8a0800cc906d7bb8f8ac0d5664bdf691b2ca7690

- sbd-inquisitor: Do not create duplicate servants (bsc#1033934, bsc#1065748)
- sbd-inquisitor: Correctly look up servant by device name (bsc#1033934, bsc#1065748)

Loading...

Yan Gao's avatar
author source maintainer

I don't see anything is wrong in here.Could you please check this? Thanks.


Dominique Leuenberger's avatar

The _service file is invalid (the revision mentioned therein does not exist)

The %{commit} variable is not expanded by the source validator.

My proposal would be to use this diff:

Index: _service
===================================================================
--- _service    (revision ae26b49bbcba81905386f7c3d210e86b)
+++ _service    (working copy)
@@ -3,8 +3,8 @@
     <param name="scm">git</param>
     <param name="exclude">.git</param>
     <param name="url">https://github.com/ClusterLabs/sbd.git</param>
-    <param name="revision">opensuse</param>
-    <param name="versionformat">1.3.1.git.%ct.%h</param>
+    <param name="revision">a7a7d792b9922f19bbace276c8a154e157a4f99c</param>
+    <param name="versionformat">1.3.1+git.%cd.%h</param>
     <param name="changesgenerate">enable</param>
   </service>

And then use Source: %{name}-%{version}.tar.xz

Whenever you need to do an update from then on, you simply change the 'revision' to the new tag you want to track (or remove it, if you want to track mastre) and run osc service dr


Yan Gao's avatar
author source maintainer

Thanks for the tips. Thought your check script wouldn't mind the disabled source service :) Created a new one: https://build.opensuse.org/request/show/547090


Dominique Leuenberger's avatar

you can run the test locally too:

osc service lr source_validator

Request History
Yan Gao's avatar

yan_gao created request

- Update to version 1.3.1+20171130.ecbdf9c:
* Build: cluster-servant: Compile with pacemaker-2.0

- Fix: build error with glibc 2.25
- Fix: gcc format string error
- Upstream version cs: a7a7d792b9922f19bbace276c8a154e157a4f99c

- Replace references to /var/adm/fillup-templates with new
%_fillupdir macro (boo#1069468)

- Bump to 1.3.1
- Add commands to test/query watchdogs
- Upstream version cs: a74b4d25a3eb93fe1abbe6e3ebfd2b16cf48873f (v1.3.1)

- man: Call "-P" option "Pacemaker integration" in the description (bsc#1033600)
- sbd-inquisitor: Do not use watchdog if the conflicting options "-W" and "-w /dev/null" are both supplied (bsc#1047376)
* Drop bug-1047376_sbd-not-use-watchdog-conflicting-options.patch which has been merged upstream
- sbd-inquisitor: Enable pacemaker integration by default as advertised in sysconfig.sbd (bsc#1046421, bsc#1033600)
* Drop bug-1046421_sbd-enable-pacemaker-integration-by-default.patch which has been merged upstream
- sbd-inquisitor: Respect the obsolete option SBD_WATCHDOG for backward compatibility (bsc#1047372)
* Drop bug-1047372_sbd-SBD_WATCHDOG-compatibility.patch which has been merged upstream
- Upstream version cs: 681ce1acbda12754eb97fb91f9a7306ff368452f

- cluster-servant: check for corosync 2Node mode
- disk-servant: signal reset request via exit-code
- improve reboot after sysrq_trigger
- Upstream version cs: 8a0800cc906d7bb8f8ac0d5664bdf691b2ca7690

- sbd-inquisitor: Do not create duplicate servants (bsc#1033934, bsc#1065748)
- sbd-inquisitor: Correctly look up servant by device name (bsc#1033934, bsc#1065748)


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto added repo-checker as a reviewer

Please review build success


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Staging Bot's avatar

staging-bot added as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:76"


Staging Bot's avatar

staging-bot accepted review

Picked openSUSE:Factory:Staging:adi:76


Repo Checker's avatar

repo-checker accepted review

cycle and install check passed


Dominique Leuenberger's avatar

dimstar accepted review


Staging Bot's avatar

staging-bot accepted review

ready to accept


Staging Bot's avatar

staging-bot approved review

ready to accept


Dominique Leuenberger's avatar

dimstar_suse accepted request

Accept to openSUSE:Factory

openSUSE Build Service is sponsored by