Overview
Request History
luca_b created request
KDE Applications 17.12.0 final (release on 2017-12-14)
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
staging-bot set openSUSE:Factory:Staging:N as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:N"
staging-bot accepted review
Picked openSUSE:Factory:Staging:N
licensedigger declined review
@babelworx declined the legal report with the following comment: Many GPL-3.0+ files:
kget-17.12.0/transfer-plugins/mmsthreads/dlgmms.cpp
kget-17.12.0/transfer-plugins/mmsthreads/dlgmms.h
kget-17.12.0/transfer-plugins/mmsthreads/mmsdownload.cpp
kget-17.12.0/transfer-plugins/mmsthreads/mmsdownload.h
kget-17.12.0/transfer-plugins/mmsthreads/mmsthread.cpp
kget-17.12.0/transfer-plugins/mmsthreads/mmsthread.h
kget-17.12.0/transfer-plugins/mmsthreads/mmstransfer.cpp
kget-17.12.0/transfer-plugins/mmsthreads/mmstransfer.h
kget-17.12.0/transfer-plugins/mmsthreads/mmstransferfactory.cpp
kget-17.12.0/transfer-plugins/mmsthreads/mmstransferfactory.h
licensedigger declined request
@babelworx declined the legal report with the following comment: Many GPL-3.0+ files:
kget-17.12.0/transfer-plugins/mmsthreads/dlgmms.cpp
kget-17.12.0/transfer-plugins/mmsthreads/dlgmms.h
kget-17.12.0/transfer-plugins/mmsthreads/mmsdownload.cpp
kget-17.12.0/transfer-plugins/mmsthreads/mmsdownload.h
kget-17.12.0/transfer-plugins/mmsthreads/mmsthread.cpp
kget-17.12.0/transfer-plugins/mmsthreads/mmsthread.h
kget-17.12.0/transfer-plugins/mmsthreads/mmstransfer.cpp
kget-17.12.0/transfer-plugins/mmsthreads/mmstransfer.h
kget-17.12.0/transfer-plugins/mmsthreads/mmstransferfactory.cpp
kget-17.12.0/transfer-plugins/mmsthreads/mmstransferfactory.h
luca_b reopened request
The files indicated in the comment ("mmsthreads") aren't built for openSUSE, nor installed.
licensedigger accepted review
ok
repo-checker accepted review
cycle and install check passed
dimstar accepted review
dimstar_suse accepted review
ready to accept
dimstar_suse approved review
ready to accept
dimstar_suse accepted request
Accept to openSUSE:Factory
@wolfi323 Can you look into how the plugins are handled (linked/loaded at runtime), given you touched the kget codebase recently?
The plugins are loaded at runtime.
But we don't build this particular plugin (mms) at all in the openSUSE package (would need an additional build requirement on libmms-devel).
does the kget code provides the GPL3.0+ license file ? would probably be enough in this case.
AFAICS, no.