Overview

Request 571690 superseded

- Do not condition sources they all need to be present in src rpm
- Add conditionals for python2 and python3
- Use full url for github downloads instead of handmade tarball
- Use make_install macro
- Apply py3 enablement patches everywhere, no effect on py2 code
- Drop python3 split spec file as it is not needed and use only
python3
* As there are no dependent packages on python-ibus directly
people should repoint their scripts to the python3 variant
* Makefiles do not allow building both at once so stick only
with py3 as we are disabling python2 slowly anyway
- Drop 12.2 KDE icons as the codestreams are long out of support
- Drop the kde4 icons too as we are plasma5 based now and enable
appindicator integration for plasma5 conditionaly under KDE
condition

Loading...

Hillwood Yang's avatar

Please don't drop python3-ibus, ibus-table need it. We should package python3-ibus and python-ibus together.


Tomáš Chvátal's avatar

There is only python3-ibus, no python-ibus, we plan to drop python2 for leap15 in base system and ibus is quite core


Hillwood Yang's avatar

Each of them can't be dropped as well. ibus-sunpinyin still work on python2 and python-ibus. ibus-sunpinyin is still useful for Chinese users. I think we should wait upstream of sunpinyin migrate it to python3.


Tomáš Chvátal's avatar

Not really a choice. Either someone from SUSE or community has to migrate it to python3 as it is on SLE too maybe the desktop team could be of help. @yfjiang any chance you could check this up?


Yifan Jiang's avatar

Thanks @scarabeus_iv, @hillwood :-)

@hillwood, am I right ibus-sunpinyin is the only thing being concerned for python compatibility issue for Chinese input? How about those popular engines like, as far as I can name, ibus-libpinyin and ibus-googlepinyin. Do you have some ideas if they work smoothly with python3 engine?


Hillwood Yang's avatar

ibus-pinyin, ibus-sunpinyin, ibus-googlepinyin and libgooglepinyin are all written with python2, we need migrate all of them to python3. ibus-libpinyin have been migrated to python3, so these is no problem form ibus-libpinyin.

It seem that there would be just a bit changes for the work about migrating ibus-pinyin to python3, I will try it in free time.

Of course, We can drop python2 if they work smoothly with python3 engine.


Yifan Jiang's avatar

@scarabeus_iv, @hillwood, I spent some time today, it seems sunpinyin's dependency on python-ibus are mostly on the preference setup window. This patch should just work:

https://build.opensuse.org/package/show/home:yfjiang:branches:M17N/ibus-sunpinyin

While I am not an expert in ibus area, feel free to improve :-)


Yifan Jiang's avatar

@hillwood, I meant - would you like to have a try if it works for you?


Yifan Jiang's avatar

FYI - I've submitted to replace sunpinyin's dependency:

https://build.opensuse.org/request/show/568436


Hillwood Yang's avatar

I tested it, please read my email.


Staging Bot's avatar

@ftake: review reminder


Fuminobu Takeyama's avatar

Please resubmit request after the problem is resolved.

Request History
Tomáš Chvátal's avatar

scarabeus_iv created request

- Do not condition sources they all need to be present in src rpm
- Add conditionals for python2 and python3
- Use full url for github downloads instead of handmade tarball
- Use make_install macro
- Apply py3 enablement patches everywhere, no effect on py2 code
- Drop python3 split spec file as it is not needed and use only
python3
* As there are no dependent packages on python-ibus directly
people should repoint their scripts to the python3 variant
* Makefiles do not allow building both at once so stick only
with py3 as we are disabling python2 slowly anyway
- Drop 12.2 KDE icons as the codestreams are long out of support
- Drop the kde4 icons too as we are plasma5 based now and enable
appindicator integration for plasma5 conditionaly under KDE
condition


Fridrich Strba's avatar

fstrba superseded request

Still possible to make it build

openSUSE Build Service is sponsored by