Overview
Request 591961 superseded
Import of catatonit v0.1.1. This is required for Docker so that 'docker run
--init' works correctly (note we don't use the upstream docker-init).
- Created by cyphar
- In state superseded
- Superseded by 592758
- Open review for openSUSE:Factory:Staging:adi:10
Request History
cyphar created request
Import of catatonit v0.1.1. This is required for Docker so that 'docker run
--init' works correctly (note we don't use the upstream docker-init).
licensedigger accepted review
ok
dimstar_suse added as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:10"
dimstar_suse accepted review
Picked openSUSE:Factory:Staging:adi:10
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
repo-checker accepted review
cycle and install check passed
dimstar declined review
Use %license COPYING instead of %doc COPYING
The Summary/description calling it 'brain-dead' does not give a lot of hope to anybody trying to install it. Possibly rephraze that?
dimstar declined request
Use %license COPYING instead of %doc COPYING
The Summary/description calling it 'brain-dead' does not give a lot of hope to anybody trying to install it. Possibly rephraze that?
superseded by 592758
We would not really want software with dead innards.
Use
%license COPYINGinstead of%doc COPYINGI just tried this and it causes the build to fail on SLE12. Since this package is also going to be submitted for the containers module, that's an issue.
Is there any compatibility macro that you have which I could use? Or should I just do %if 0?%{is_opensuse} ?
%license is already supported on 12SP3, and the directory-not-owned error is going to be fixed with a maintenance update on SP2
Alternatively, you can do:
%if 0{?suse_version} >= 1500 %license COPYING %else %doc COPYING %endifAs for the tag-line, I can change it to something like "incredibly simple container init and signal forwarder". However users aren't going to install this directly, most of the time it'll just be pulled in with a Docker installation and they won't care about this package.