Overview

Request 613094 accepted

No description set
Loading...

Dominique Leuenberger's avatar

+%if 0%{?sle_version} || 0%{?suse_version}

=> if %?suse_version is sufficent: there is no product with a sle_version that does not also define a suse_version


Markos Chandras's avatar

Thank you for the suggestion. I will fix it in the next iteration if that's OK with you.


Dominique Leuenberger's avatar

Why next? This weird construct is being introduced in this submission only. Cleaning it up right before it hits the product(s) sounds better


Markos Chandras's avatar

OK no problem. I was planning to clean it up from SLE first and then sync with Factory but I can do it the other way around




Jan Engelhardt's avatar

I think we now have upstream macros like %systemd_post in suse too.


Markos Chandras's avatar

I can have a look at it as well in the next iteration but I also need to make sure these macros work in maintained SLE distros so we don't deviate.

Request History
Markos Chandras's avatar

markoschandras created request


Saul Goodman's avatar

licensedigger accepted review

ok


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto added repo-checker as a reviewer

Please review build success


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Staging Bot's avatar

staging-bot added openSUSE:Factory:Staging:adi:12 as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:12"


Staging Bot's avatar

staging-bot accepted review

Picked openSUSE:Factory:Staging:adi:12


Repo Checker's avatar

repo-checker accepted review

cycle and install check passed


Dominique Leuenberger's avatar

dimstar accepted review


Staging Bot's avatar

staging-bot accepted review

ready to accept


Staging Bot's avatar

staging-bot approved review

ready to accept


Dominique Leuenberger's avatar

dimstar_suse accepted request

Accept to openSUSE:Factory

openSUSE Build Service is sponsored by