This request is superseded by
request 613094
(Show diff)
Overview
Request 612948 superseded
No description set
- Created by mrdocs
- In state superseded
- Superseded by 613094
-
Open review for
opensuse-review-team
- Open review for openSUSE:Factory:Staging:adi:12
Loading...
Request History
mrdocs created request
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
staging-bot added openSUSE:Factory:Staging:adi:12 as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:12"
staging-bot accepted review
Picked openSUSE:Factory:Staging:adi:12
repo-checker accepted review
cycle and install check passed
licensedigger accepted review
ok
markoschandras superseded request
review comments addressed in https://build.opensuse.org/request/show/613094
+%if 0%{?sle_version} || 0%{?suse_version}=> if %?suse_version is sufficent: there is no product with a sle_version that does not also define a suse_version
Thank you for the suggestion. I will fix it in the next iteration if that's OK with you.
Why next? This weird construct is being introduced in this submission only. Cleaning it up right before it hits the product(s) sounds better
OK no problem. I was planning to clean it up from SLE first and then sync with Factory but I can do it the other way around
"Factory first" :)
True :)
I think we now have upstream macros like
%systemd_postin suse too.I can have a look at it as well in the next iteration but I also need to make sure these macros work in maintained SLE distros so we don't deviate.