Overview
Request 626125 superseded
There are two commits in this request:
- Updated to version 5.0.0.
- Update gramps-no-translations-check.patch.
- Remove obsolete webcal.py.diff.
and
- Added optional Recommends: and Suggests: according to README.md
(see https://github.com/gramps-project/gramps/blob/v5.0.0/README.md ) The added Recommends is for optional gramps features, while the Suggests are for some third party add-ons.
- Created by sebschub
- In state superseded
- Superseded by 626434
-
Open review for
gnome-maintainers
Request History
sebschub created request
There are two commits in this request:
- Updated to version 5.0.0.
- Update gramps-no-translations-check.patch.
- Remove obsolete webcal.py.diff.
and
- Added optional Recommends: and Suggests: according to README.md
(see https://github.com/gramps-project/gramps/blob/v5.0.0/README.md ) The added Recommends is for optional gramps features, while the Suggests are for some third party add-ons.
gnome-review-bot accepted review
Check script succeeded
Thanks for the contribution. We follow some costumes under GNOME project to keep up the quality of the packages. Among them are .changes entries.
When we add package to build/run time requirements we usually name the packages being added to better document this kind of change and track any possible future problems.
This entry is standardized to '-Update to version x.y.z:'. And it always have at least one entry. I would summarize it, as the 5.0.0 NEWS entries are too extensive, to:
And last but not least:
We usually say something like "Remove(or 'drop') file.patch(or .diff): fixed(or 'merged') upstream." so we know it landed upstream, which is the case here.