Overview

Request 636357 accepted

- Update to 2.0.0
- bump soversion to 2
- require cmake >= 3.1.0
- execute unit tests (make check)
- remove cmake option 'enable-ladspa' as it's now enabled by default
- add conditionals to spec file to allow builds for other RPM-based distributions

Loading...

Tomáš Chvátal's avatar

The %check part seems wrong, you just need to run make check, no need to re-configure the package. Alternatively use %ctest macro there that should work too...


Tomáš Chvátal's avatar

Also there is some optflags issue:

[ 96s] I: File is compiled without RPM_OPT_FLAGS [ 96s] W: fluidsynth no-rpm-opt-flags <cmdline>:/home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/drivers/fluid_alsa.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/bindings/fluid_rtkit.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/drivers/fluid_oss.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/drivers/fluid_jack.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/drivers/fluid_pulse.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/utils/fluid_conv.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/utils/fluid_hash.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/utils/fluid_list.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/utils/fluid_ringbuffer.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/utils/fluid_settings.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/utils/fluid_sys.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/sfloader/fluid_defsfont.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/sfloader/fluid_sfont.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/sfloader/fluid_sffile.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/sfloader/fluid_samplecache.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/rvoice/fluid_adsr_env.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/rvoice/fluid_chorus.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/rvoice/fluid_iir_filter.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/rvoice/fluid_lfo.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/rvoice/fluid_rvoice.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/rvoice/fluid_rvoice_dsp.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/rvoice/fluid_rvoice_event.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/rvoice/fluid_rvoice_mixer.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/rvoice/fluid_rev.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/synth/fluid_chan.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/synth/fluid_event.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/synth/fluid_gen.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/synth/fluid_mod.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/synth/fluid_synth.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/synth/fluid_synth_monopoly.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/synth/fluid_tuning.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/synth/fluid_voice.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/midi/fluid_midi.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/midi/fluid_midi_router.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/midi/fluid_seqbind.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/midi/fluid_seq.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/drivers/fluid_adriver.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/drivers/fluid_mdriver.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/bindings/fluid_cmd.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/drivers/fluid_aufile.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/bindings/fluid_filerenderer.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/bindings/fluid_ladspa.c, /home/abuild/rpmbuild/BUILD/fluidsynth-2.0.0/src/fluidsynth.c


Tom Mbrt's avatar

%cmake may or may not create a 'build' subdirectory. On openSUSE it does, on Fedora, Mageia and friends it doesn't. And as %ctest is not available on Fedora, Megeia... I preferred to call %cmake again to make sure 'make check' is executed in the correct folder.

That RPM_OPT_FLAGS issue does not occur in openSUSE_Leap_15.0 and openSUSE_Leap_42.3. Looks like an openSUSE_Factory issue to me.


Tomáš Chvátal's avatar

But why do you handle Fedoraa/Mageia and other distributions, this package is for openSUSE, it is not even anywhere in OBS linked and build for those distributions, as such you can simply use the macros provided to you by openSUSE...


Tomáš Chvátal's avatar

Especially if you already use suse-only systemd macros which won't work anywhere else.


Tom Mbrt's avatar

I'm using fluidsynth as build dependency for various distros in an OBS subproject (home:derselbst:anmp), which is derived from multimedia:libs. Admittedly a little unmaintained currently. Yet I am interested in having only a single .spec file that allows building for those distros. Preferably the .spec file from multimedia:libs. fluidsynth should be simple enough to allow this. The systemd macro could just be %if-ed away.

So, do you insist on an openSUSE only .spec file or do you accept a cross distro spec file?


Tomáš Chvátal's avatar

I do not insist on the package being only for openSUSE I am just saying that the package as is won't still work for other distributions in this state.

Request History
Tom Mbrt's avatar

derselbst created request

- Update to 2.0.0
- bump soversion to 2
- require cmake >= 3.1.0
- execute unit tests (make check)
- remove cmake option 'enable-ladspa' as it's now enabled by default
- add conditionals to spec file to allow builds for other RPM-based distributions


Takashi Iwai's avatar

tiwai accepted request

Thanks.

openSUSE Build Service is sponsored by