Overview
Request 663786 accepted
Plasma 5.14.5
- Created by Vogtinator
- In state accepted
Loading...
Request History
Vogtinator created request
Plasma 5.14.5
wolfi323 accepted request
Looks fine though, I'll just do the mentioned changelog adjustments afterwards.
If the "Remote patches" lines were generated automatically, that should better be fixed though... ;-)
There's a typo in breeze-gtk.changes:
Remote patches, now upstream
(should be "Remove")
Also, " * GTK theme treeview style typo/bug fix" is no change in 5.15.5, it was actually in 5.12.7 and 5.14.2 already, maybe better remove it?
discover.changes:
"pk: Don't the dependencies button if there aren't dependencies"
Should better be Don't show the dependencies button... I suppose.
Same typo in plasma5-desktop.changes: Remote patches, now upstream (should be "Remove")
Maybe a "bug" in a script?
I actually type that manually, so I have no idea how that happened...
IMO autogenerated changelogs shouldn't be edited manually - either upstream needs to be taught how to write commit messages properly or the changelog generator needs to become smarter.
Ok, I can just ignore them again in the future...
I somehow got the impression we wanted to try to "improve" them, in the last couple of weeks at least.
And this in libkscreen2.changes is not really useful:
+ * Revert "Fix uninstalled run unit tests: set LIBRARY_OUTPUT_DIRECTORY for plugins"
+ * Fix uninstalled run unit tests: set LIBRARY_OUTPUT_DIRECTORY for plugins
That are actually changes from July...
https://cgit.kde.org/libkscreen.git/log/?qt=grep&q=LIBRARY_OUTPUT_DIRECTORY
:-/
Apparently 5.12 was never merged down to 5.14 and master until now...
xdg-desktop-portal-kde:
The added KIO BuildRequires isn't necessary in this update AFAICS, but as it has been added in master (i.e. will be required for 5.15), that's fine I suppose.
Yup - cmake failed because of kwindowsystem and I wasn't patient enough to find out whether it's actually required, so I just added it anyway.