Overview
Request 673403 superseded
Build version 0.3.3
- Created by worldcitizen
- In state superseded
- Supersedes 672054
- Superseded by 673608
@TheBlackCat, @alarrosa, @aplanas, @cyberiad, @czerw, @dirkmueller, @glaubitz, @mcepl, @mimi_vx, @pavlix, @posophe, @rjschwei, @scarabeus_iv, @sleep_walker, @tbechtold: review reminder
Why are the tests disabled? Could they be enabled? Also requires python should not be needed.
The condition between %doc and %License is really not needed in flies section. And last the python- build requires should really go away too.
Request History
worldcitizen created request
Build version 0.3.3
scarabeus_iv declined request
You actually just removed the test part and didn't correct any other comment from the previous request. Also we try hard to run the tests not just blindly hide it (esp. if the tests should work like in this package is the case).
worldcitizen reopened request
I've copied test from another python.spec
Test fails in the build process because it needs network access.
That means that test shouldn't have been there in the first place.
If you don't want to accept it, please say so than I will delete package.
I don't want to waste my time like this.
scarabeus_iv declined request
Okay that explains the tests, see not that hard if you actually say what you are doing; yet you didn't fix the other part of the comment I gave you previously:
'The condition between %doc and %License is really not needed in flies section. And last the python- build requires should really go away too.'
worldcitizen superseded request
superseded by 673608
