This request is superseded by
request 676207
(Show diff)
Overview
Request 676198 superseded
No description set
- Created by fos
- In state superseded
- Superseded by 676207
-
Open review for
factory-staging
-
Open review for
repo-checker
Loading...
Request History
fos created request
licensedigger accepted review
ok
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
dimstar declined request
+%__aclocal -I m4
+%__automake --add-missing --copy --force
+%__autoconf
Yacks - don't use the %__ indirection macros.
See https://en.opensuse.org/openSUSE:Specfile_guidelines#Macros_vs_shell_commands
+BuildRequires: autoconf-archive
do you REALLY need autoconf-archive? What stuff from there do you rely on? (autoconf itself is not in the -archive)
Yes, it is required for the Python macros (AX_PYTHON_MODULE).
I've replaced the automake macros with a direct ./autgen.sh call - is that better?