Request 678070: Submit openvpn - openSUSE Build Service

This request supersedes: request 678069 (Show diff)

Overview

Request 678070 accepted

- Drop use of $FIRST_ARG in openvpn.spec
The use of $FIRST_ARG was probably required because of the
%service_* rpm macros were playing tricks with the shell positional
parameters. This is bad practice and error prones so let's assume
that no macros should do that anymore and hence it's safe to assume
that positional parameters remains unchanged after any rpm macro
call.

Created by fbui almost 6 years ago
In state accepted
Package maintainers: rjain and rmax
Supersedes 678069

Submit openvpn

Comments for request 678070 1

Staging Bot (staging-bot) - over 5 years ago

@rmax: review reminder

Login required, please login in order to comment

Request History

fbui created request almost 6 years ago

- Drop use of $FIRST_ARG in openvpn.spec
The use of $FIRST_ARG was probably required because of the
%service_* rpm macros were playing tricks with the shell positional
parameters. This is bad practice and error prones so let's assume
that no macros should do that anymore and hence it's safe to assume
that positional parameters remains unchanged after any rpm macro
call.

rmax accepted review over 5 years ago

OK

rmax approved review over 5 years ago

OK

rmax accepted request over 5 years ago

Thanks

openSUSE Build Service is sponsored by