This breaks strace: https://github.com/strace/strace/issues/94

Awaiting a fix from upstream shortly...

Stephan Kulow (coolo) - over 5 years ago

How optimistic are you now? :(

Other breakages seen:

• Build failed java-1_8_0-openjdk (i586) @fstrba
• Build failed postfix (i586) @varkoly

They both seem tonot like kernel 5.x

@fstrba: hotspot.tar.xz:hotspot-4e4ead43a282/make/linux/Makefile says:

SUPPORTED_OS_VERSION = 2.4% 2.5% 2.6% 3% 4%

5% is missing and I would make it more generic. Something like [5-9] and [1-9][0-9] in terms of regular expressions.

Jiri Slaby (jirislaby) - over 5 years ago

author source maintainer

The test was removed in later hotspot. Java:Factory/java-1_8_0-openjdk works just fine. So could somebody move sr#681627 here if it does not depend/affects anything in Staging:F?

---

Jiri Slaby (jirislaby) - over 5 years ago

author source maintainer

sr#681627 was accepted, so this one should be solved!

Jan Engelhardt (jengelh) - over 5 years ago

reviewer

It's exactly this stupidness (of SUPPORTED_OS_VERSIONS) that made Linus bump the kernel version even faster.

Basically they could and should just put SUPPORTED_OS_VERSION = % in there.

No one's seriously going to run this on 2.2 anymore anyway.

@darix, @computersalat: postfix-3.3.2.tar.gz:postfix-3.3.2/src/util/sys_defs.h considers only LINUX2..4, but -DLINUX5 is on the command line now.

The below diff helps:

--- a/src/util/sys_defs.h +++ b/src/util/sys_defs.h @@ -748,7 +748,8 @@ extern int initgroups(const char , int) / * LINUX. */ -#if defined(LINUX2) || defined(LINUX3) || defined(LINUX4) +#if defined(LINUX2) || defined(LINUX3) || defined(LINUX4) || defined(LINUX5) ||\ + defined(LINUX6) #define SUPPORTED #define UINT32_TYPE unsigned int #define UINT16_TYPE unsigned short

But I would perhaps define LINUX4 for everything >= 4 in makedefs instead (e.g. in postfix-linux45.patch).

Jiri Slaby (jirislaby) - over 5 years ago

author source maintainer

Something like in sr#681744.