Request 724830 (accepted)

This request supersedes: request 724650 (Show diff)

Overview

Request 724830 accepted

- Fixes bugs bsc#1145796: Add tightPNG encoding
* Apply novnc-1.0.0-add-encoding-support-for-TightPNG.patch
This patch cherry-picks commit 2c813a33f to novnc 1.0.0 to enable tightPNG encoding.
This encoding is needed to allow noVNC to work with instances that
run on ESX hypervisors. It is not possible to update the Pike package
to noVNC 1.1.0 as that version is not supported with openstack-nova until Rocky.

Created by kberger65 over 5 years ago
In state accepted
Supersedes 724650

Submit novnc

Comments for request 724830 2
Comments for request 724650 1

Thomas Bechtold (tbechtold) - over 5 years ago

target maintainer

can you add a patch comment so we know that this is already fixed upstream? See https://en.opensuse.org/openSUSE:Packaging_Patches_guidelines
there is no need to create a list in a list (with - and *) if the second list has only 1 entry.
please provide the info in .changes that is useful for a user. The git sha is not useful. Also the info that we can't update the novnc package is not useful. See also https://en.opensuse.org/openSUSE:Creating_a_changes_file_(RPM)

Dirk Mueller (dirkmueller) - over 5 years ago

target maintainer

Agreed with your comment, sorry didn't see this in time when accepting it.

Dirk Mueller (dirkmueller) - over 5 years ago

target maintainer

where is the Rocky change? this was only fixed in 1.1.0 wasn't it? can you also amend the changes entry with the the patch name that is being added to the spec ?

should we maybe just upgrade to 1.1.0? I see there were various attempts at getting this fixed upstream.

Request History

kberger65 created request over 5 years ago

dirkmueller accepted request over 5 years ago

Places

Overview