Overview
Request 728027 accepted
Plasma 5.16.5. Not built yet after replacing all tars with the latest version (got respun)
- Created by Vogtinator
- In state accepted
Loading...
Request History
Vogtinator created request
Plasma 5.16.5. Not built yet after replacing all tars with the latest version (got respun)
Vogtinator accepted request
I'll accept and edit the .changes manually
LGTM, just 2 long lines in plasma5-addons.changes and plasma5-workspace.changes
The one in plasma5-workspace actually is that long:
https://cgit.kde.org/plasma-workspace.git/commit/?id=9b3c4d1986f37543b9cb8b826715ac68bd17a288
But "Fix build The QMutex include in AbstractRunner was removed in https://cgit.kde.org/krunner.git/commit/?id=ac6814b1387bc0c790928ec5b62f43c1764994d6 11" should be truncated to just "Fix build" like in the upstream release announcement IMHO.
https://cgit.kde.org/kdeplasma-addons.git/commit/?id=c389606dc950ed66d26eb6f2c7b2a2346103fbb0
It seems the script joins the lines if there is no blank line in between, maybe this should/could be changed?
The separator between subject and body is a blank line. So technically everything before that is the subject. You can see for yourself if you use "git log --oneline". So ignoring the line continuation would be possible, but technically wrong.
I'm aware of that, but I'd say the question is what's better suited to our use case. It's not the first time that something like this happens, unfortunately...
and http URLs that shall be changed to https
That can also be done separately though IMHO, it's not related to this update...