Request 735307: Submit ocaml-rpm-macros

You're not reviewing the full diff of request 735307 , but the diff to the superseded request 734957 (Show full diff)

Overview

Request 735307 accepted

split ocaml-rpm-macros from ocaml.spec
trim changes file

Created by olh about 5 years ago
In state accepted
Supersedes 734957

Submit ocaml-rpm-macros

Comments for request 735307 0
Comments for request 734957 3

Dominique Leuenberger (dimstar) - about 5 years ago

reviewer

plus:

ocaml-rpm-macros.x86_64: W: no-binary
The package should be of the noarch architecture because it doesn't contain
any binaries.

ocaml-rpm-macros.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/lib/rpm/macros.d/macros.ocaml-rpm-macros

Olaf Hering (olh) - about 5 years ago

author source maintainer

It provides 'do_opt' to decide what to do. rpmlint can not possibly know that.

%config does not mean configuration either. It means "keep a copy of that file in case it is modified anyway", but that was too long to type, so the authors of %config fooled the world with that shorter variant. Looks like they fooled you and the rpmlint authors as well.

Dominique Leuenberger (dimstar) - about 5 years ago

reviewer

and allowing a user to modify a file makes sense on 'configuration files' - which is NOT the case for RPM macros.