Overview

Request 734957 superseded

split ocaml-rpm-macros from ocaml.spec
trim changes file


Dominique Leuenberger's avatar

plus:

ocaml-rpm-macros.x86_64: W: no-binary
The package should be of the noarch architecture because it doesn't contain
any binaries.

ocaml-rpm-macros.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/lib/rpm/macros.d/macros.ocaml-rpm-macros

Olaf Hering's avatar
author source maintainer

It provides 'do_opt' to decide what to do. rpmlint can not possibly know that.

%config does not mean configuration either. It means "keep a copy of that file in case it is modified anyway", but that was too long to type, so the authors of %config fooled the world with that shorter variant. Looks like they fooled you and the rpmlint authors as well.


Dominique Leuenberger's avatar

and allowing a user to modify a file makes sense on 'configuration files' - which is NOT the case for RPM macros.

Request History
Olaf Hering's avatar

olh created request

split ocaml-rpm-macros from ocaml.spec
trim changes file


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Dominique Leuenberger's avatar

dimstar_suse added as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:29"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked openSUSE:Factory:Staging:adi:29


Dominique Leuenberger's avatar

dimstar declined review

sorry - %config %{_rpmmacrodir}/* -> there are not CONFIG files (they are in /usr/share for a reason)


Dominique Leuenberger's avatar

dimstar declined request

sorry - %config %{_rpmmacrodir}/* -> there are not CONFIG files (they are in /usr/share for a reason)


Olaf Hering's avatar

olh reopened request

Incorrect reject reason.


Dominique Leuenberger's avatar

dimstar declined review

We do NOT want users to change the macros on their system...

if they want to override them, they can do so in .etc.. decline is correct


Dominique Leuenberger's avatar

dimstar declined request

We do NOT want users to change the macros on their system...

if they want to override them, they can do so in .etc.. decline is correct


Olaf Hering's avatar

olh superseded request

superseded by 735307

openSUSE Build Service is sponsored by