Overview
Request 734957 superseded
split ocaml-rpm-macros from ocaml.spec
trim changes file
- Created by olh
- In state superseded
- Supersedes 734497
- Superseded by 735307
- Open review for openSUSE:Factory:Staging:adi:29
Request History
olh created request
split ocaml-rpm-macros from ocaml.spec
trim changes file
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
dimstar_suse added as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:29"
dimstar_suse accepted review
Picked openSUSE:Factory:Staging:adi:29
dimstar declined review
sorry - %config %{_rpmmacrodir}/* -> there are not CONFIG files (they are in /usr/share for a reason)
dimstar declined request
sorry - %config %{_rpmmacrodir}/* -> there are not CONFIG files (they are in /usr/share for a reason)
olh reopened request
Incorrect reject reason.
dimstar declined review
We do NOT want users to change the macros on their system...
if they want to override them, they can do so in .etc.. decline is correct
dimstar declined request
We do NOT want users to change the macros on their system...
if they want to override them, they can do so in .etc.. decline is correct
superseded by 735307
plus:
It provides 'do_opt' to decide what to do. rpmlint can not possibly know that.
%config does not mean configuration either. It means "keep a copy of that file in case it is modified anyway", but that was too long to type, so the authors of %config fooled the world with that shorter variant. Looks like they fooled you and the rpmlint authors as well.
and allowing a user to modify a file makes sense on 'configuration files' - which is NOT the case for RPM macros.