Overview

Request 737179 superseded

Comments addressed, minimum Qt version updated.

Loading...

Fabian Vogt's avatar

ecm has: +BuildRequires: kf5-filesystem >= 5.11.0?


Christophe Giboudeaux's avatar

kf5-filesystem's version is... 20170414, I can remove the version check completely


Fabian Vogt's avatar

"Too many changes to list here. " has trailing whitespace



Fabian Vogt's avatar

kcalendercore.spec has -DBUILD_TESTING=ON but no %check section?


Christophe Giboudeaux's avatar

I think it was needed at some point to have a test program installed. That doesn't seem to be the case anymore


Fabian Vogt's avatar

"No bugs fixed since 5.62.0" sounds wrong. It means that no kde# bugs were mentioned, but that doesn't necessarily mean there were no bugfixes at all...


Christophe Giboudeaux's avatar

I'm opened to suggestions


Fabian Vogt's avatar

What about just not adding it? Mentioning bug reports if there are any should be enough



Fabian Vogt's avatar

Where is %{_kf5_plugindir}/kf5/kded/proxyscout.so gone in kio?


Christophe Giboudeaux's avatar

Wrong buildrequires in KUF. proxyscout was ported from qtscript to qml. Updating


Fabian Vogt's avatar

LGTM otherwise.


Christophe Giboudeaux's avatar

I'm also changing the Qt deps to 5.11.0, new SR incoming

Request History
Christophe Giboudeaux's avatar

cgiboudeaux created request

Comments addressed, minimum Qt version updated.


openSUSE Build Service is sponsored by