the changes entry won't work - no user will have the tar ball available.

Andreas Warnke (awarnke) - over 4 years ago

author source maintainer target maintainer

Danke Stephan,

Ich hab ein schönes skript gefunden (changelog2spec) welches mir die release-notes Datei konvertiert. Hoffe, das passt jetzt? Grüße, Andreas.

https://build.opensuse.org/package/show/home:awarnke/crystal_facet_uml

Please take a look at some of spec files for other packages i.e in this project, I also strongly recommend checking https://en.opensuse.org/openSUSE:Packaging_guidelines and/or using tool called spec-cleaner to tidy up spec file.

For cmake building please use macros such as %cmake and %cmake_build

Do not set release to anything else than 0, it is overriden by obs anyways.

Provides: crystal-facet-uml1 seems redundant

15+Requires: gtk3 16+Requires: sqlite3 - those seem redundant as well, most runtime dependencies are automatically generated.

Andreas Warnke (awarnke) - over 4 years ago

author source maintainer target maintainer

Hallo Martin,

Danke fürs ansehen und deine Kommentare! Ich hab versucht, das umzusetzen. Passt das so?

Grüße Andreas

https://build.opensuse.org/package/show/home:awarnke/crystal_facet_uml

---

Martin Pluskal (pluskalm) - over 4 years ago

target maintainer

It looks good, please make new sr

Thank you for checkin! I'll work on these points soon. - Grüße aus Franken

@WernerFink, @coolo, @dirkmueller, @duwe, @jones_tony, @matz2, @msmeissn, @neilbrown, @olh, @pluskalm, @rguenther, @schubi2, @sleep_walker, @tiwai: review reminder