Overview

Request 755251 accepted

- Fix incorrect prefix removal in rpm macro %perl_gen_filelist (boo#1152247)

Jan Baier's avatar
Jan Baier (jbaier_cz) -
author

Although I did not get any feedback, I refactored the request. Can it be accepted this way?

Staging Bot's avatar
Staging Bot (staging-bot) -

@mlschroe: review reminder

Michael Schröder's avatar
Michael Schröder (mlschroe) -
target maintainer

Hmm, can't we just use

el=${dir#$base_dir}

Jan Baier's avatar
Jan Baier (jbaier_cz) -
author

We probably can, there are more things which could be nicer. I just tried to keep the spirit.

Stephan Kulow's avatar
Stephan Kulow (coolo) -

One of you guys needs to move

Jan Baier's avatar
Jan Baier (jbaier_cz) -
author

I am ok with both variant. However in case of rewriting, I would go for a lot more rewrites, so that patch would be bigger.

Dirk Stoecker's avatar
Dirk Stoecker (dstoecker) -
target maintainer

Beeeeep.

Accept or remake, that's here the question....

Dirk Stoecker's avatar
Dirk Stoecker (dstoecker) -
target maintainer

Hello?

Staging Bot's avatar
Staging Bot (staging-bot) -

@mlschroe: review reminder

Request History
Jan Baier's avatar

jbaier_cz created request

- Fix incorrect prefix removal in rpm macro %perl_gen_filelist (boo#1152247)

Dirk Stoecker's avatar

dstoecker accepted request

openSUSE Build Service is sponsored by
Places