Overview

Request 755756 accepted

- Add gnome-control-center-can-not-find-usermod.patch:
+ Fix: g-c-c use command usermod to verify user is valid, usermod
is in /usr/sbin, environment PATH doesn't include this path, so
g-c-c can't find this command. Upstream commit c6be204
(bsc#1158341 glgo#GNOME/gnome-control-center!653).
+ Fix: initialize GError* to NULL before use.
Upstream commit 54caab7b.


Yifan Jiang's avatar

@xiaoguang_wang Thanks for working on this, just 2 cents:

  1. This seems from another commit, it would be better to find an explicit way to include that issue/MR in patch, spec and changelog.
  • GError *error = NULL;
  1. The commit id in the patch doesn't seem reflect the real situation, see:

https://gitlab.gnome.org/GNOME/gnome-control-center/commit/354d900d4326aa79664be55f8d773001ee22c648

Request History
xiaoguang wang's avatar

xiaoguang_wang created request

- Add gnome-control-center-can-not-find-usermod.patch:
+ Fix: g-c-c use command usermod to verify user is valid, usermod
is in /usr/sbin, environment PATH doesn't include this path, so
g-c-c can't find this command. Upstream commit c6be204
(bsc#1158341 glgo#GNOME/gnome-control-center!653).
+ Fix: initialize GError* to NULL before use.
Upstream commit 54caab7b.


GNOME Review Bot's avatar

gnome-review-bot accepted review

Check script succeeded


GNOME Review Bot's avatar

gnome-review-bot approved review

Check script succeeded


Dominique Leuenberger's avatar

dimstar accepted request

openSUSE Build Service is sponsored by