Request 756998: Submit purge-kernels-service

You're not reviewing the full diff of request 756998 , but the diff to the superseded request 756881 (Show full diff)

Overview

Request 756998 accepted

purge-kernels-service (jsc#SLE-10162, jsc#SLE-10465)

This adds separate package that contains purge-kernels.service
Requires change to dracut that drops the same.
Preferably this package should be added to some pattern that pulls it in by default.

Created by michals almost 5 years ago
In state accepted
Supersedes 756881

Submit purge-kernels-service

Comments for request 756998 0
Comments for request 756881 5

Michal Suchanek (michals) - almost 5 years ago

author source maintainer

This package is only these two files. Do I need to include a license anywhere? The purge-kernel.service was initially added to dracut package which is GPL2 but was never part of the upstream code.

Martin Pluskal (pluskalm) - almost 5 years ago

There are obvious errors - how do you make sure that systemd macros are present without any dependency? Is empty line really necessary part of describtion? Why set buildroot and defattr - both are not needed for ages.

Michal Suchanek (michals) - almost 5 years ago

author source maintainer

systemd is part of the base system for way longer than defattr is not required. What other dependency is needed for systemd macros to work? Where is it documented?

Can't whatever processes description just throw away leading empty line?

Setting buildroot and defattr is part of the template you get when editing an empty spec file. Deleting them is work. They are not required but setting them should not break anything either.

Michal Suchanek (michals) - almost 5 years ago

author source maintainer

Also shoudn't invoking those macros add the dependency as required?

Martin Pluskal (pluskalm) - almost 5 years ago

RTFM https://en.opensuse.org/openSUSE:Systemd_packaging_guidelines

Request History

michals created request almost 5 years ago

purge-kernels-service (jsc#SLE-10162, jsc#SLE-10465)

This adds separate package that contains purge-kernels.service
Requires change to dracut that drops the same.
Preferably this package should be added to some pattern that pulls it in by default.