Overview

Request 756998 accepted

purge-kernels-service (jsc#SLE-10162, jsc#SLE-10465)

This adds separate package that contains purge-kernels.service
Requires change to dracut that drops the same.
Preferably this package should be added to some pattern that pulls it in by default.


Michal Suchanek's avatar

This package is only these two files. Do I need to include a license anywhere? The purge-kernel.service was initially added to dracut package which is GPL2 but was never part of the upstream code.


Martin Pluskal's avatar

There are obvious errors - how do you make sure that systemd macros are present without any dependency? Is empty line really necessary part of describtion? Why set buildroot and defattr - both are not needed for ages.


Michal Suchanek's avatar

systemd is part of the base system for way longer than defattr is not required. What other dependency is needed for systemd macros to work? Where is it documented?

Can't whatever processes description just throw away leading empty line?

Setting buildroot and defattr is part of the template you get when editing an empty spec file. Deleting them is work. They are not required but setting them should not break anything either.


Michal Suchanek's avatar

Also shoudn't invoking those macros add the dependency as required?


Request History
Michal Suchanek's avatar

michals created request

purge-kernels-service (jsc#SLE-10162, jsc#SLE-10465)

This adds separate package that contains purge-kernels.service
Requires change to dracut that drops the same.
Preferably this package should be added to some pattern that pulls it in by default.


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Staging Bot's avatar

staging-bot added openSUSE:Factory:Staging:adi:35 as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:35"


Staging Bot's avatar

staging-bot accepted review

Picked "openSUSE:Factory:Staging:adi:35"


Dominique Leuenberger's avatar

dimstar accepted review


Dominique Leuenberger's avatar

dimstar_suse accepted review

Staging Project openSUSE:Factory:Staging:adi:35 got accepted.


Dominique Leuenberger's avatar

dimstar_suse approved review

Staging Project openSUSE:Factory:Staging:adi:35 got accepted.


Dominique Leuenberger's avatar

dimstar_suse accepted request

Staging Project openSUSE:Factory:Staging:adi:35 got accepted.

openSUSE Build Service is sponsored by