[sddm-theme] Fix initial focus after SDDM QQC2 Port Revert "[sddm-theme] Fix initial focus after SDDM QQC2 Port" (kde#414875)

So that fixed an issue that didn't exist in the previous release?

Fabian Vogt (favogt) - almost 5 years ago

Yep. It existed on the Plasma/5.17 branch only.

Looks fine.

Just something I noticed due to the PAM file change in kscreenlocker:
We still set -DKDE4_COMMON_PAM_SERVICE=xdm in plasma5-workspace, I suppose that could eventually be removed...
It's apparently not used there at all since years:
https://cgit.kde.org/plasma-workspace.git/commit/ConfigureChecks.cmake?id=45ce8fc8bbbc8134d30e88bce0941b033332fc13

Fabian Vogt (Vogtinator) - almost 5 years ago

author target maintainer

Dropped from KUF

Fabian Vogt (Vogtinator) - almost 5 years ago

author target maintainer

Hm, my earlier comment about cmake complaining about that define being unused got lost apparently...

PS: One thing though:
The PAM file in kscreenlocker was changed to %config(noreplace) due to a bug report.
https://bugzilla.opensuse.org/show_bug.cgi?id=1114258

I'm not sure it's a good idea to remove that again. Although I assume that's actually irrelevant when the file gets installed to /usr/etc/pam.d/... (Leap 15.1 doesn't, I'm not sure about 15.2)

Fabian Vogt (favogt) - almost 5 years ago

The bug report should've been RESOLVED INVALID - that's the entirely wrong way of doing that. Instead, common-auth should've been modified. So I don't care about breaking this...