Overview
Request 764183 accepted
- Fix setting CMAKE_INSTALL_LIBDIR in cmake macro
* This is a relative path, see `cmake --help-module GNUInstallDirs`
- Do NOT set -DCMAKE_SKIP_RPATH:BOOL=OFF
* A lot of applications have private libraries in a subdirectory
and require linking with RPATH which is totally valid.
- Created by gladiac
- In state accepted
-
Package maintainers:
dirkmueller and
simotek
Loading...
Request History
gladiac created request
- Fix setting CMAKE_INSTALL_LIBDIR in cmake macro
* This is a relative path, see `cmake --help-module GNUInstallDirs`
- Do NOT set -DCMAKE_SKIP_RPATH:BOOL=OFF
* A lot of applications have private libraries in a subdirectory
and require linking with RPATH which is totally valid.
simotek accepted request
I'll accept this one
@gladiac can you be more specific? which application requires a specific rpath? the issue is that runpaths are restricted in openSUSE distributions, so just setting them means we break a lot of builds.
I'm okay with taking the libdir->lib change.
I know a lot of application which put private libraries in %{_libdir}/%{name}. The reason is that those are internal libraries without a public API.
Just to name two of them: * Samba * darktable
RPATH isn't a bad thing it is there for a reason. cmake has very good RPATH handling and only suggests to set it if really needed. It probably had issues in the past with autofools but certainly not with cmake ;-)
If a project sets the RPATH incorrectly, it should be fixed. This way we just hide problems.
@dirkmueller, @simotek, @sumski: review reminder