Request 764792 (accepted)

Overview

Request 764792 accepted

- use cmake generics in marcos.cmake

Created by cjunghans almost 5 years ago
In state accepted
Package maintainers: dirkmueller and simotek

Submit cmake

Comments for request 764792 7

Anonymous User (_nobody_) - almost 5 years ago

This comment has been deleted

Christoph Junghans (cjunghans) - almost 5 years ago

author

I should say this is all backwards compatible and the only new macro is cmake_builder_deps, which is optional.

Martin Pluskal (pluskalm) - almost 5 years ago

target maintainer

Calling cmake instead of builders has allegedly performance impact that is noticeable.

Christoph Junghans (cjunghans) - almost 5 years ago

author

Isn't that just an O(1) launch overhead.

Martin Pluskal (pluskalm) - almost 5 years ago

target maintainer

Well yes, and this overhead is causing noticeable performance issues.

Christoph Junghans (cjunghans) - almost 5 years ago

author

Hmm,

I did the following test to measure the launch overhead: ``` cd votca-tools/build ln -s /usr/bin/ninja ninja cmake -GNinja -DCMAKE_MAKE_PROGRAM=$PWD/ninja .. ln -sf /bin/true ninja time cmake --build .

real 0m0.005s user 0m0.001s sys 0m0.005s ``` (compare here: https://build.opensuse.org/package/show/home:cjunghans:branches:devel:tools:building/votca-tools)

which is basically nothing. After the launch through CMake there should be no difference.

Staging Bot (staging-bot) - almost 5 years ago

@dirkmueller, @simotek, @sumski: review reminder

Request History

cjunghans created request almost 5 years ago

- use cmake generics in marcos.cmake

dirkmueller accepted request almost 5 years ago

Places

Overview