Overview
Request 772215 accepted
- The camsource v4l1 module has logic errors opening the video
device that incorrectly perform a channel set when a grab window
set (frame size, fps, etc) is intended. The error handling from
the invalid channel set causes the configuration frame size and
fps settings to be discarded and replaced with the current
settings active on the video device. The result is that running a
v4l(1/2) application on a given camera before using camsource on
the same camera means camsource has the grab window attributes
from the other application not the one specified in camsource
configuration
- camsource-v4l-conf-video_window-overwrite.patch
Please shorten the changelog.
Put the patch description in the patch header (git format). Also, remove the whitespace only changes from the patch.
It depends what you mean by "whitespace only changes". Several lines have space indents in the location of tab indented surrounding code (the majority of the source is tab indented) making absurd appearance in an editor (conditional with higher indentation than the block it makes conditional). We can fight about it but the space indented code is broken source even though it is compile time functional.
Request History
dmair created request
- The camsource v4l1 module has logic errors opening the video
device that incorrectly perform a channel set when a grab window
set (frame size, fps, etc) is intended. The error handling from
the invalid channel set causes the configuration frame size and
fps settings to be discarded and replaced with the current
settings active on the video device. The result is that running a
v4l(1/2) application on a given camera before using camsource on
the same camera means camsource has the grab window attributes
from the other application not the one specified in camsource
configuration
- camsource-v4l-conf-video_window-overwrite.patch
msmeissn accepted request
ok
