Request 787504: Submit rapid-photo-downloader

You're not reviewing the full diff of request 787504 , but the diff to the superseded request 787401 (Show full diff)

Overview

Request 787504 accepted

- removed all manual typelib requires again as we fixed the
underlying problem in libdbusmenu (forwarded request 787503 from darix)

Created by darix over 4 years ago
In state accepted
Supersedes 787401

Submit rapid-photo-downloader

Comments for request 787504 0
Comments for request 787401 2

Dominique Leuenberger (dimstar) - over 4 years ago

reviewer

@darix

28+# normally the unity typelib should pull those, but it seems it is not doing that atm. pull here for now.
29+Requires:       typelib(Dbusmenu) = 0.4
30+Requires:       typelib(Dee) = 1.0

That's not what I'm used to from you. Why not fix the actual issue of Unity not pulling in the correct typelibs? (see sr#787406)

31+# does not have an import in the code but upstream documented it as a required
32+Requires:       typelib(UnityExtras) = 7.0

You trust doc more than code? Probably was removed from the code at one point but the doc was not updated

Marcus Rueckert (darix) - over 4 years ago

reviewer source maintainer

The question is ... if the typelib dependency generator is broken it sounds like a bigger problem. I wanted to leave that to the experts for that code and have a working package in the mean time.
actually ... see this comment:

https://discuss.pixls.us/t/rapid-photo-downloader-0-9-20-is-released/17083/10

So it seems openSUSE splitting out the UnityExtra typelib seems to be a bug. The Unity typelib seems to use it without having an explicit import. I wanted to report that as a bug today.