Overview

Request 787504 accepted

- removed all manual typelib requires again as we fixed the
underlying problem in libdbusmenu (forwarded request 787503 from darix)


Dominique Leuenberger's avatar

@darix

28+# normally the unity typelib should pull those, but it seems it is not doing that atm. pull here for now.
29+Requires:       typelib(Dbusmenu) = 0.4
30+Requires:       typelib(Dee) = 1.0

That's not what I'm used to from you. Why not fix the actual issue of Unity not pulling in the correct typelibs? (see sr#787406)

31+# does not have an import in the code but upstream documented it as a required
32+Requires:       typelib(UnityExtras) = 7.0

You trust doc more than code? Probably was removed from the code at one point but the doc was not updated


Marcus Rueckert's avatar
reviewer source maintainer
  1. The question is ... if the typelib dependency generator is broken it sounds like a bigger problem. I wanted to leave that to the experts for that code and have a working package in the mean time.

  2. actually ... see this comment:

https://discuss.pixls.us/t/rapid-photo-downloader-0-9-20-is-released/17083/10

So it seems openSUSE splitting out the UnityExtra typelib seems to be a bug. The Unity typelib seems to use it without having an explicit import. I wanted to report that as a bug today.

Request History
Marcus Rueckert's avatar

darix created request

- removed all manual typelib requires again as we fixed the
underlying problem in libdbusmenu (forwarded request 787503 from darix)


Dominique Leuenberger's avatar

dimstar_suse added openSUSE:Factory:Staging:adi:44 as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:44"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked "openSUSE:Factory:Staging:adi:44"


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Dominique Leuenberger's avatar

dimstar accepted review


Saul Goodman's avatar

licensedigger accepted review

ok


Dominique Leuenberger's avatar

dimstar_suse accepted review

Staging Project openSUSE:Factory:Staging:adi:44 got accepted.


Dominique Leuenberger's avatar

dimstar_suse approved review

Staging Project openSUSE:Factory:Staging:adi:44 got accepted.


Dominique Leuenberger's avatar

dimstar_suse accepted request

Staging Project openSUSE:Factory:Staging:adi:44 got accepted.

openSUSE Build Service is sponsored by