Overview
Request 798889 superseded
- Update to 3.10+git20200429.6875e3a
* #730: Base OAuth2 Client now has a consistent way of managing the scope:
it consistently relies on the scope provided in the constructor if any,
except if overridden temporarily in a method call. Note that in particular
providing a non-None scope in prepare_authorization_request or
prepare_refresh_token does not override anymore self.scope forever, it
is just used temporarily.
* #726: MobileApplicationClient.prepare_request_uri and MobileApplicationClient.
parse_request_uri_response, ServiceApplicationClient.prepare_request_body,
and WebApplicationClient.prepare_request_uri now correctly use the default
scope provided in constructor.
* #725: LegacyApplicationClient.prepare_request_body now correctly uses the
default scope provided in constructor
- Created by glaubitz
- In state superseded
- Superseded by 798900
Request History
glaubitz created request
- Update to 3.10+git20200429.6875e3a
* #730: Base OAuth2 Client now has a consistent way of managing the scope:
it consistently relies on the scope provided in the constructor if any,
except if overridden temporarily in a method call. Note that in particular
providing a non-None scope in prepare_authorization_request or
prepare_refresh_token does not override anymore self.scope forever, it
is just used temporarily.
* #726: MobileApplicationClient.prepare_request_uri and MobileApplicationClient.
parse_request_uri_response, ServiceApplicationClient.prepare_request_body,
and WebApplicationClient.prepare_request_uri now correctly use the default
scope provided in constructor.
* #725: LegacyApplicationClient.prepare_request_body now correctly uses the
default scope provided in constructor
superseded by 798900
Why should we switch to git version? Why it is not based on _service? the Version field even with service seems wrong it is not 3.10 Also what I see the git version does not need mock module dependency anymore, so how about you just backport that commit only?
I switched to a git version because upstream hasn't released new version for a longer time and the updated version fixes the testsuite. I had a brief stab at backporting the mock fix but the patch didn't apply cleanly at all.
I didn't use a service file because I considered this a one-time exception so that we can get the Azure submission fixed.
You're right about the mock dependency in any case, I will remove it.
Suggestions for addressing the testsuite failure? Not sure whether upstream wants to release anytime soon.
The test failure on mock is just because of syntax change. If you just go in the release folder and replace all 'from mock import ..'. or 'import mock' with 'from unittest import mock' you are set without having to generate git version; and if you really think we should have git version you should ask upstream first to release and if that fails use the _service to auto-generate it. The mock module is not ment to be used except as a feature backport to older pythons -> even on your azure stuff you should be able to not depend on the latest mock ; it seems upstream in git just auto bumped the requirement as it was released.
Resubmitted with a simple switch from mock to unittest.mock which worked.
Thanks!
I'll try to replace "import mock" with "from unittest import mock" globally and see if that helps.