Your change will impact all other arches, for example s390x, is it expected ? What is original failure ? only arm specific ?

Guillaume GARDET (Guillaume_G) - almost 4 years ago

author

My goal was to fix build on all archs which do not support -m32 and -m64 flags, including aarch64 and %{arm}, but more archs are probably affected (riscv?).

s390 seems to support -m31 and -m64.

Please note that this patch is more than 2 years old but is just a resubmission. ;)

I don't know about s390x, but these flags (-m32 & -m64) cause breakage on other arches (like linux for arm* for example), and these changes have already been applied in the upstream sources for this and other qore packages, so least for arm* they are correct, and because they were only implemented for x86 and ppc originally, the patch makes sense to me from that point of view.