Request 824081 (accepted)

Overview

Request 824081 accepted

No description set

Created by sgrunert almost 4 years ago
In state accepted

Submit cri-o

Comments for request 824081 7

Dominique Leuenberger (dimstar) - almost 4 years ago

reviewer

 1@@ -355,7 +355,7 @@
 2 # Paths to directories where CNI plugin binaries are located.
 3 plugin_dirs = [
 4         "/opt/cni/bin/",
 5-        "/usr/lib/cni/",
 6+        "[@LIBEXECDIR](https://build.opensuse.org/users/LIBEXECDIR)@/cni/",
 7 ]

That actually sounds wrong by definition - plugins are not libexec - they are not 'executables called by libraries'

See the definition at https://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch04s07.html

Dominique Leuenberger (dimstar) - almost 4 years ago

reviewer

Or is this really 'binarues' 'called', not dlopen'ed? than it can be argued as being right (you certainly know more of the internas and can assess if the move makes sense taking FHS into account)

Sascha Grunert (sgrunert) - almost 4 years ago

author

@gmbr3 may I ask you to support here regarding @dimstar's question?

Callum Farmer (gmbr3) - almost 4 years ago

@dimstar @sgrunert One minute, sorry this didn't for some reason ping me.

Callum Farmer (gmbr3) - almost 4 years ago

Still figuring it out how it is called. Fedora and Mageia use /usr/libexec/cni but I'll still need to look as they never followed FHS.

Callum Farmer (gmbr3) - almost 4 years ago

@dimstar @sgrunert Right, I think I have come to a decision regarding this, FHS 3.0 allows executables(including plugin executables) in libexec as long as they don't use lib aswell. And, according to the docs for CNI: CNI_PATH`: List of paths to search for CNI plugin executables. CNI path is the /usr/libexec/cni directory so since they are plugin executables, I think this is allowed by FHS 3.0 standards. And, upstream seems to have accepted /usr/libexec/cni as a correct path when RH changed it (gh#cri-o/cri-o#953)

So if this is also ok by @dimstar then other plugins such as podman have conf files pointing to /usr/lib need to be changed.

I am actually still not sure how they are called.

Dominique Leuenberger (dimstar) - almost 4 years ago

reviewer

Thanks for double checking - let's go with this then