Overview
Request 829840 accepted
New package. Removed static libraries. Now using %version
- Created by gabrielftg
- In state accepted
- Supersedes 827601
Some comments, more or less 'bad':
- +%{_libdir}/lib*.a > Please see https://en.opensuse.org/openSUSE:Packaging_guidelines#Static_Libraries (in short: no statics lib packaged) (this one is fatal)
- 45+Requires: libpvec1 = 1.0.4 => you most likely want = %{version} here. It will almost certainly forgotten to be updatedn on each version bump
- I'd rather call the devel package pveclib-devel (pveclib being the upstream name and matching the includedir name)
Request History
gabrielftg created request
New package. Removed static libraries. Now using %version
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
dimstar_suse added as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:82"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:adi:82"
dimstar accepted review
licensedigger accepted review
ok
dimstar_suse accepted review
Staging Project openSUSE:Factory:Staging:adi:82 got accepted.
dimstar_suse approved review
Staging Project openSUSE:Factory:Staging:adi:82 got accepted.
dimstar_suse accepted request
Staging Project openSUSE:Factory:Staging:adi:82 got accepted.
On the review for request 827601, dimstar made 3 comments: 1. no static libraries (fixed); 2. use %version (fixed); 3. rename the devel package (not fixed, see explanation below).
I did not rename the devel package (from libpvec-devel to pveclib-devel) because doing so causes the following lintian warning:
"pveclib-devel.ppc64le: W: no-dependency-on pveclib*/pveclib-libs/libpveclib*"
My question to dimstar is:
Your comment was just a suggestion/preference, or is it required? I like the idea of having a devel package that has the same name as the library package, because, in my experience, it makes it easier to zypper search for the devel package. On the other hand, I understand that other libraries have different names for the devel package, e.g. zlib-devel and libz1. So, if I were to change the name of the devel package, should I add a lintian filter for the warning?