This request supersedes:
request 832373
(Show diff)
Overview
Request 833181 accepted
- Rework patch trusting the compiler will remove dead code properly
when debug output is disabled (as it is in the spec file):
* noqDebug-qWarnings.patch
- Update to 0.9.3+16.04.20160218:
* Ported tests to Qt5
- Use a Source url that works
Loading...
target maintainer
Due to -DQT_NO_DEBUG_OUTPUT -DQT_NO_WARNING_OUTPUT, the patch might be entirely pointless meanwhile. Can you check?
Login required, please
login
in order to comment
Request History
alarrosa created request
- Rework patch trusting the compiler will remove dead code properly
when debug output is disabled (as it is in the spec file):
* noqDebug-qWarnings.patch
- Update to 0.9.3+16.04.20160218:
* Ported tests to Qt5
- Use a Source url that works
Vogtinator accepted request
Did just removing the patch not work?
No. The parenthesis in the definition of _DMTRACE is conflicting with the way QT_NO_QDEBUG_MACRO is defined and it doesn't build if the patch is just removed.
LGTM
@Vogtinator, @cgiboudeaux, @dirkmueller, @luca_b, @tittiatcoke: review reminder