Yeah, we absolutely need update-timeline.patch back, otherwise it'll be a pain later. We introduced them for a very good reason and AFAICT it's still fully valid.
TBH, it is more of a pain to rebase that patch all the time.
I have been asking for that reason and have never gotten an answer. Those timeline tags will only be used by developers if they are available upstream. They are not. The tag PATCH-FIX-UPSTREAM is wrong. They will only be available when there exists such a version. Such a version can only be supported by an updated package.
The %If (Qt_5_15_0 -) directive will work perfectly fine with future versions and the unpatched Timeline.
The reason is that SIP and PyQt5 will not build with a version of Qt newer than what they know about. And their releases lag behind the Qt releases, for obvious reasons. So this means breaking a lot of stuff if a submission for Qt is sent, because it will cause build failures.
The reason is that SIP and PyQt5 will not build with a version of Qt newer than what they know about.
I already wrote a few weeks ago: That is not true.
Patching the %Timeline directive has no effect on whether the package will build or not. It only provides a means for specifying versions in the %If directive.
With PyQt5 the version number of PyQt5 is tied, to a certain extent, to the version of Qt v5 so that:
The major version will always be 5.
For a particular minor version n it will build against any version of Qt v5, but will not support any new features introduced in Qt v5.n+1 or later.
It will support all the features of supported modules of Qt v5.n or earlier.
Support for new modules may be added to PyQt5 at any time. This would result in a change of patch version only.
The major and minor versions of the latest release of PyQt5 will be the same as the latest release of Qt v5.
The patch versions of PyQt5 and Qt v5 are entirely unrelated to each other.
So, for example, PyQt5 v5.1 will build against Qt v5.2 but will not support any new features introduced in Qt v5.2. PyQt5 v5.1 will support all the features of supported modules of Qt v5.0 and those new features introduced in Qt v5.1.
bnavigator
Please don't self accept until you have given reasonable time for others to chime in.
Yeah, we absolutely need update-timeline.patch back, otherwise it'll be a pain later. We introduced them for a very good reason and AFAICT it's still fully valid.
TBH, it is more of a pain to rebase that patch all the time.
I have been asking for that reason and have never gotten an answer. Those timeline tags will only be used by developers if they are available upstream. They are not. The tag PATCH-FIX-UPSTREAM is wrong. They will only be available when there exists such a version. Such a version can only be supported by an updated package.
The
%If (Qt_5_15_0 -)directive will work perfectly fine with future versions and the unpatched Timeline.https://github.com/search?q=Qt_5_15_0&type=code 19K matches, mostly (if not all of them) bundles of the PyQt5 SIP files itself.
https://github.com/search?q=Qt_5_15_1&type=code 1 match (the patch itself)
The reason is that SIP and PyQt5 will not build with a version of Qt newer than what they know about. And their releases lag behind the Qt releases, for obvious reasons. So this means breaking a lot of stuff if a submission for Qt is sent, because it will cause build failures.
https://build.opensuse.org/request/show/830222#comment-1297874
Patching the
%Timelinedirective has no effect on whether the package will build or not. It only provides a means for specifying versions in the%Ifdirective.https://www.riverbankcomputing.com/static/Docs/PyQt5/installation.html#understanding-the-correct-version-to-install