Overview

Request 834727 accepted

No description set
Loading...

Libor Pechacek's avatar

A question. As the changelog suggests, there was an API change in 7.1.0. There was also PROJ_API_VERSION change in the top-level CMakeLists.txt: https://github.com/OSGeo/PROJ/commit/720d3fd19b56162dbaf01bcb0eccfb6b296cf4c6#diff-af3b638bc2a3e6c650974192a53c7291. Shouldn't the sover .spec variable be bumped from 19 to 20 as well, please?


Jan Engelhardt's avatar

This is a thing without a clear answer.

  1. Makefile.am was changed by upstream from -version-info 19:0:0 to -version-info 20:0:1, so that's good.
  2. But, both version-info strings lead to libproj.so.19 under the elf-linux-gnu platform. This is intentional and not completely wrong, but it's also not completely right, as it breaks certain program expectations.
  3. One could either try to fix libtool (which isn't all that easy given tarballs ship their own copy of libtool),
  4. Upstream could add ELF symbol version maps, or
  5. Upstream could just bump it to 20:0:0.

Libor Pechacek's avatar

Thanks, Jan, for the fast response. I've in the meantime also studied the problem and figured out that the number comes from libtool. Reading the rules for version-info (https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html#Updating-version-info), I would say all is fine. current was increased and revision reset because an interface was added. age was increased for the same reason. Given that no interfaces have been removed (only deprecated), age didn't have to be reset to zero. The resulting .so version 19 is then OK, in my opinion, as no interfaces have been removed or altered and I'm for keeping the status quo.


Jan Engelhardt's avatar

Even though no interface have been removed, the loader (/lib64/ld.so) — and package manager too — can't tell from the name alone if a "libproj.so.19" has the new interface or not, which is a problem if you have a package/program that may be using the new interface.

Request History
Martin Pluskal's avatar

pluskalm created request


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Dominique Leuenberger's avatar

dimstar_suse added openSUSE:Factory:Staging:adi:7 as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:7"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked "openSUSE:Factory:Staging:adi:7"


Dominique Leuenberger's avatar

dimstar accepted review


Dominique Leuenberger's avatar

dimstar_suse accepted review

Staging Project openSUSE:Factory:Staging:adi:7 got accepted.


Dominique Leuenberger's avatar

dimstar_suse approved review

Staging Project openSUSE:Factory:Staging:adi:7 got accepted.


Dominique Leuenberger's avatar

dimstar_suse accepted request

Staging Project openSUSE:Factory:Staging:adi:7 got accepted.

openSUSE Build Service is sponsored by