Request History
pluskalm created request
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
dimstar_suse added openSUSE:Factory:Staging:adi:7 as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:7"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:adi:7"
dimstar accepted review
dimstar_suse accepted review
Staging Project openSUSE:Factory:Staging:adi:7 got accepted.
dimstar_suse approved review
Staging Project openSUSE:Factory:Staging:adi:7 got accepted.
dimstar_suse accepted request
Staging Project openSUSE:Factory:Staging:adi:7 got accepted.
A question. As the changelog suggests, there was an API change in 7.1.0. There was also
PROJ_API_VERSION
change in the top-level CMakeLists.txt: https://github.com/OSGeo/PROJ/commit/720d3fd19b56162dbaf01bcb0eccfb6b296cf4c6#diff-af3b638bc2a3e6c650974192a53c7291. Shouldn't thesover
.spec variable be bumped from 19 to 20 as well, please?This is a thing without a clear answer.
Makefile.am
was changed by upstream from-version-info 19:0:0
to-version-info 20:0:1
, so that's good.libproj.so.19
under the elf-linux-gnu platform. This is intentional and not completely wrong, but it's also not completely right, as it breaks certain program expectations.Thanks, Jan, for the fast response. I've in the meantime also studied the problem and figured out that the number comes from
libtool
. Reading the rules forversion-info
(https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html#Updating-version-info), I would say all is fine. current was increased and revision reset because an interface was added. age was increased for the same reason. Given that no interfaces have been removed (only deprecated), age didn't have to be reset to zero. The resulting .so version 19 is then OK, in my opinion, as no interfaces have been removed or altered and I'm for keeping the status quo.Even though no interface have been removed, the loader (/lib64/ld.so) — and package manager too — can't tell from the name alone if a "libproj.so.19" has the new interface or not, which is a problem if you have a package/program that may be using the new interface.