Overview
Request 840275 superseded
- Created by Pharaoh_Atem
- In state superseded
- Superseded by 883123
-
Open review for
licensedigger
Request History
Pharaoh_Atem created request
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
dimstar_suse set openSUSE:Factory:Staging:E as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:E"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:E"
dimstar accepted review
dimstar_suse added factory-staging as a reviewer
Being evaluated by group "factory-staging"
dimstar_suse accepted review
Unstaged from project "openSUSE:Factory:Staging:E"
dimstar_suse set openSUSE:Factory:Staging:M as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:M"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:M"
dimstar_suse changed priority to moderate => important
raising priority for openSUSE:Factory:Staging:M
dimstar_suse added factory-staging as a reviewer
Being evaluated by group "factory-staging"
dimstar_suse accepted review
Unstaged from project "openSUSE:Factory:Staging:M"
dimstar_suse declined review
sr#841543 has newer source and is from the same project
dimstar_suse declined request
sr#841543 has newer source and is from the same project
superseded by 883123
This seems to be the candidate to break the pkg-config file of rav1e, resulting utlimately in the build failure of ffmpeg-4
diff of rav1e.pc between old and new carge_c version:
--- rav1e.pc 2020-09-18 16:03:14.000000000 +0200 +++ rav1e.pc 2020-10-09 11:37:29.000000000 +0200 @@ -1,7 +1,7 @@ prefix=/usr exec_prefix=${prefix} libdir=/usr/lib64 -includedir=/usr/include +includedir=/usr/include/rav1e Name: rav1e Description: The fastest and safest AV1 encoderCC rav1e maintainer: @gladiac
Breaks rav1e
Unignored: returned to active backlog.
I guess the right way is to fix ffmpeg?
No - the error is in the way rav1e is being generated.
+includedir=/usr/include/rav1e, but then cflags uses -I${includedir}/rav1e
which results in one level rav1e too many; this was not the case when building rav1e with older versions of cargo-c
I've opened https://github.com/lu-zero/cargo-c/issues/121
Upstream confirmed the bug.
@dimstar See https://build.opensuse.org/request/show/841528