Overview

Request 863364 accepted

- Update to version 1.5:
* Implement tc[io]flush methods & deprecate broken
purge_buffers methods
* Add program to test buffer flush (purge) functionality
* Add kernel driver auto attach/detach.
See new AUTO_DETACH_REATACH_SIO_MODULE option
* Add ftdi_setflowctrl_xonxoff()
* ftdi_eeprom / eeprom handling:
+ Unify handling of all boolean eeprom flags
+ Add device release number support
+ Add channel_a_driver support for type xxR chips
+ Add support for group0 drive levels on x232H chips
+ Fix handling of high_current_drive parameter
+ Fix inverted handling of VCP driver field for TYPE_R chips
+ New --verbose option for eeprom decode operation
* Add example code for async mode
* Add SPDX license identifiers to the core library &
ftdi_eeprom
* Various python SWIG wrapper improvements
* Various cmake file improvements
* Fix small bugs in error code paths
- Correct License, the library is LGPL-2.1-only (see SPDX headers),
while various other parts are GPL-2.0-only (with and without
linking exceptions).
- Add Fix-building-unit-tests-without-FTDIPP.patch

Loading...

Michal Suchanek's avatar

Where is the classpath exception?

I see no java there, no hit on classpath.

On the other hand, there is license for cmake scripts which looks like 3 clause BSD, and it applies at least to the srpm


Stefan Brüns's avatar
  1. The "with-classpath-exception" is not new.
  2. 'Classpath-exception' is a license concept. It can be applied to any language, not only java. See spdx.org.
  3. Good luck going through all 13000 packages and adding 'AND BSD-*' everywhere some small build script is permissely licensed.

Michal Suchanek's avatar
  1. you are touching the license - I would not look at it otherwise
  2. you still did not answer how it applies
  3. The upstream is quite explicit about that here. It is an exception rather than the norm

Stefan Brüns's avatar

I corrected the obviously wrong LGPL-2.1-or-later part, everything else is unchanged.

The exception is stated in the LICENSE file. Read it.


Michal Suchanek's avatar

It also quite obviously claims LGPL-2.0-only


Stefan Brüns's avatar

LICENSE does not specify LGPL-2.0-only.

SPDX headers and comments explicitly say LGPL-2.1-only: http://developer.intra2net.com/git/?p=libftdi;a=blob;f=src/ftdi.c;h=03d7b071800b4cdbd741538fc7d374c1d28b4419;hb=HEAD


Michal Suchanek's avatar

Yes, the SPDX identifiers are in conflict with LICENSE and COPYING.LIB


Stefan Brüns's avatar

The current LGPL-2.1-or-later is wrong, it is not matched by any reference in the sources or accompanying documents.

LGPL-2.1-only is clearly correct for the libftdi1 library itself.

Leave the legal review with @legal-review if you are not sure, and raise your issues with them.



Michal Suchanek's avatar

Output of check script:
A patch (libftdi-cmake.patch) is being deleted without this removal being mentioned in the changelog.

Request History
Stefan Brüns's avatar

StefanBruens created request

- Update to version 1.5:
* Implement tc[io]flush methods & deprecate broken
purge_buffers methods
* Add program to test buffer flush (purge) functionality
* Add kernel driver auto attach/detach.
See new AUTO_DETACH_REATACH_SIO_MODULE option
* Add ftdi_setflowctrl_xonxoff()
* ftdi_eeprom / eeprom handling:
+ Unify handling of all boolean eeprom flags
+ Add device release number support
+ Add channel_a_driver support for type xxR chips
+ Add support for group0 drive levels on x232H chips
+ Fix handling of high_current_drive parameter
+ Fix inverted handling of VCP driver field for TYPE_R chips
+ New --verbose option for eeprom decode operation
* Add example code for async mode
* Add SPDX license identifiers to the core library &
ftdi_eeprom
* Various python SWIG wrapper improvements
* Various cmake file improvements
* Fix small bugs in error code paths
- Correct License, the library is LGPL-2.1-only (see SPDX headers),
while various other parts are GPL-2.0-only (with and without
linking exceptions).
- Add Fix-building-unit-tests-without-FTDIPP.patch


Michal Suchanek's avatar

michals accepted request

openSUSE Build Service is sponsored by