Better use "MODULE" instead of "STATIC"

Add "# PATCH-FIX-OPENSUSE" (or preferably submit upstream)

Instead of moving the library after install, remove the explicit "LIBRARY DESTINATION lib" line(s) from the CMakeLists (cmakes default is fine), either with sed or patch.

Jan Engelhardt (jengelh) - almost 4 years ago

author source maintainer target maintainer

MODULE is stupid. The library is not a module (plugin/dlopened entity). cmake even aborts the build expectedly.

[    4s]   Target "imageio" of type MODULE_LIBRARY may not be linked into another
[    4s]   target.  One may link only to INTERFACE, OBJECT, STATIC or SHARED
[    4s]   libraries, or to executables with the ENABLE_EXPORTS property set.

---

Stefan Brüns (StefanBruens) - almost 4 years ago

target maintainer

Should be 'OBJECT', of course.

And mind your language.

Jan Engelhardt (jengelh) - almost 4 years ago

author source maintainer target maintainer

There is still /usr/lib/wp2. Trust me, the spec is quite adequate in what it does.

---

Stefan Brüns (StefanBruens) - almost 4 years ago

target maintainer

Its obviously not adequate. The *.cmake files contain /usr/lib/.

Also, version should be "0.1.0~g@TAG_OFFSET@", as "~" is "before".

As tests are already built, how about running them?

%check
%ctest

Jan Engelhardt (jengelh) - almost 4 years ago

author source maintainer target maintainer

That does not run without the (obvious) absence of gtest, which is why I did not add either so far.