This request is superseded by
request 876275
(Show diff)
Overview
Request 875637 superseded
- BuildRequire sip-devel = 5 because the build expects the sip5
executable (or even older sip from SIP v4), which was removed in
SIP v6. Force resolution to find SIP v5 because SIPv6 and SIP v4
in parallel does not work here.
- Created by bnavigator
- In state superseded
- Superseded by 876275
Loading...
Request History
bnavigator created request
- BuildRequire sip-devel = 5 because the build expects the sip5
executable (or even older sip from SIP v4), which was removed in
SIP v6. Force resolution to find SIP v5 because SIPv6 and SIP v4
in parallel does not work here.
You can omit # SECTION python build requirements and # /SECTION. Apart from that, LGTM.
without the SECTION, spec-cleaner and the equivalent obs service move the boolean dependency away from the comment and away from the python3-qt5-devel BR.
See https://build.opensuse.org/package/show/home:bnavigator:pyqt:dependers/krita?rev=11
Wouldn't 'Provides: python3-sip-devel:/usr/bin/sip' for python-sip-devel be more intuitive? then we can 'BuildRequires: /usr/bin/sip5'
When the move to the sip-devel metapackage is complete, we will have:
/usr/bin/sip
/usr/bin/sip5
. Upstream always marked this transition helper as deprecated.No need to introduce extra file providers, one can do
BuildRequires: python3-sip5-devel
then.But it is not in place yet, we are still waiting for the creation of devel:languages:python:pyqt. Submitting python-sip6-devel to KDE:Qt5 would be wrong IMHO.
/usr/bin/sip
and/usr/bin/sip5
are update-alternative controlled and provided by multiple python flavor packages (python36, python38, soon python39 ...). I think introducing a file provides tag, could create problems with the resolution to the right python flavor. Specifying primary python3-sip(5)?-devel as it is right now, does the right thing here.Wouldn't this cause problems when building on Leap 15.2 (without KDE:Qt5), which we do in KDE:Extra?
Good point. I was not aware, that you also want to support Leap 15.2 without updated PyQt5 and SIP v5 packages.
Let me try to come up with an even more complicated boolean dependency.
Turns out, a simple
BuildConflicts: python3-sip-devel >= 6
is the better solution.