Overview
74+%post 75+%fillup_only 76+%service_add_post wsdd.service 77+%tmpfiles_create %{_prefix}/lib/tmpfiles.d/wsdd.conf 78+%firewalld_reload
you missed a tmpfilesdir change; but you can do that post accept imho. will accept as-is
No idea how this can work. Creating /run/sysconfig as user wsdd? How should that work? Beside never use the name of another package or generic names in /run! This will always lead to conflicts. Dependencies are also missing. Please also use sysusers-tools and not useradd/groupadd.
It's /run/wsdd not (/run/sysconfig) which will be created. That shall be fine. For the wsdd-user I will switch to sysuser-tools.
27+install -o wsdd -g wsdd -p 0700 -d /run/sysconfig 28+ 29+echo "WSDD_ARGS=${WSDD_HOSTNAME} ${WSDD_DOMAIN} ${WSDD_INTERFACE_ARGS} \ 30+ ${WSDD_ARGS}" >/run/sysconfig/wsdd
Sure. I have both, where I shall have only /run/wssd. I will fix that.
Request History
hgraeber created request
Updated user creation and removed use of /run/sysconfig
dimstar_suse added as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:39"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:adi:39"
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
dimstar accepted review
RBrownSUSE accepted review
Staging Project openSUSE:Factory:Staging:adi:39 got accepted.
RBrownSUSE approved review
Staging Project openSUSE:Factory:Staging:adi:39 got accepted.
RBrownSUSE accepted request
Staging Project openSUSE:Factory:Staging:adi:39 got accepted.