Overview

Request 876006 accepted

Updated user creation and removed use of /run/sysconfig

Loading...

Dominique Leuenberger's avatar
 74+%post
 75+%fillup_only
 76+%service_add_post wsdd.service
 77+%tmpfiles_create %{_prefix}/lib/tmpfiles.d/wsdd.conf
 78+%firewalld_reload

you missed a tmpfilesdir change; but you can do that post accept imho. will accept as-is


Thorsten Kukuk's avatar

No idea how this can work. Creating /run/sysconfig as user wsdd? How should that work? Beside never use the name of another package or generic names in /run! This will always lead to conflicts. Dependencies are also missing. Please also use sysusers-tools and not useradd/groupadd.


Herbert Graeber's avatar

It's /run/wsdd not (/run/sysconfig) which will be created. That shall be fine. For the wsdd-user I will switch to sysuser-tools.


Dominique Leuenberger's avatar
27+install -o wsdd -g wsdd -p 0700 -d /run/sysconfig
28+
29+echo "WSDD_ARGS=${WSDD_HOSTNAME} ${WSDD_DOMAIN} ${WSDD_INTERFACE_ARGS} \
30+        ${WSDD_ARGS}" >/run/sysconfig/wsdd

Herbert Graeber's avatar

Sure. I have both, where I shall have only /run/wssd. I will fix that.

Request History
Herbert Graeber's avatar

hgraeber created request

Updated user creation and removed use of /run/sysconfig


Dominique Leuenberger's avatar

dimstar_suse added as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:39"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked "openSUSE:Factory:Staging:adi:39"


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Dominique Leuenberger's avatar

dimstar accepted review


Richard Brown's avatar

RBrownSUSE accepted review

Staging Project openSUSE:Factory:Staging:adi:39 got accepted.


Richard Brown's avatar

RBrownSUSE approved review

Staging Project openSUSE:Factory:Staging:adi:39 got accepted.


Richard Brown's avatar

RBrownSUSE accepted request

Staging Project openSUSE:Factory:Staging:adi:39 got accepted.

openSUSE Build Service is sponsored by