Overview
Request 887009 accepted
- Created by RBrownSUSE
- In state accepted
Request History
RBrownSUSE created request
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
dimstar_suse added as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:75"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:adi:75"
dimstar accepted review
jengelh added jengelh as a reviewer
see comment
jengelh added RBrownSUSE as a reviewer
Please reevaluate if the patch is really a good idea (cf. https://build.opensuse.org/request/show/887009#comment-1444010 )
jengelh accepted review
review should be on RB
RBrownSUSE accepted review
I think this patch is a good idea. You cant use any generic sslh config files anyway, we might as well have sane behaviour.
dimstar_suse accepted review
Staging Project openSUSE:Factory:Staging:adi:75 got accepted.
dimstar_suse approved review
Staging Project openSUSE:Factory:Staging:adi:75 got accepted.
dimstar_suse accepted request
Staging Project openSUSE:Factory:Staging:adi:75 got accepted.
If I read the manpage of pcreposix right, the (PCRE) regcomp function expects to be given P-regexes in all cases. Going with regex.h instead means regcomp will require B/E-regexes.
It's already bad enough that the (unmodified variant of the) software exhibits different behavior depending on which platform it was built, but now you're also changing the behavior within the context of one (fixated) platforms, which could, for example, invalidate the contents of configuration files that were written using the expectation that, on the openSUSE platform, sslh would always demand P-regexes. I would ask that you reconsider and drop the patch.