This request is superseded by
request 889954
(Show diff)
Overview
Request 889748 superseded
add to factory (bsc#1185525)
- Created by slbtongying
- In state superseded
- Supersedes 889699
- Superseded by 889954
-
Open review for
opensuse-review-team
- Open review for openSUSE:Factory:Staging:adi:17
Loading...
Request History
slbtongying created request
add to factory (bsc#1185525)
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
dimstar_suse added openSUSE:Factory:Staging:adi:17 as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:17"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:adi:17"
licensedigger accepted review
ok
superseded by 889954
The doc is huge because it uses some pictures (as a drawing app), and they are integrated with the main interface.
Thank you very much for moving this forward!
I tested if optipng could shrink those pictures and got from 7176 to 6824 kb. Someone could update it upstream, of we could run it during build (that leaves src.rpm larger)
There is only ~3mb pictures on binary rpm actually, and the src tar/rpm contains 7mb because the upstream put pictures from every release 🤦🤦
I prefer to inform the upstream to reduce the src size to benefit every one, but I think that will be in next release.
(I don't feel optimization of a few bytes from ~3mb makes any difference.)
43+Requires: typelib(Gtk) = 3.0
Most likely there are more typelib() dependencies; add BuildRequires: gobject-introspection and they should be auto-detected.
45+Recommends: %{name}-lang
is deprecated: the -lang packages has relevant supplements, which are even smarter than the simple recommends