Request 891235: Submit python-SQLAlchemy

You're not reviewing the full diff of request 891235 , but the diff to the superseded request 890816 (Show full diff)

Overview

Request 891235 accepted

No description set

Created by mcalabkova over 3 years ago
In state accepted
Supersedes 890816

Submit python-SQLAlchemy

Comments for request 891235 0
Comments for request 890816 2

Dominique Leuenberger (dimstar) - over 3 years ago

reviewer

27+%if %{python_version_nodots} < 38
28+BuildRequires:  %{python_module importlib-metadata}
29+%endif

I'm actually not sure this works as intended by you

the scheduler does not know python_version_nodots - that is only defined in the build env
even if it would: BuildRequires %{python_module FOO} would still expand to all python flavors.

dimstar_suse@zeus:~> osc buildinfo devel:languages:python python-SQLAlchemy openSUSE_Tumbleweed x86_64 | grep importlib-metadata
  <bdep name="python36-importlib-metadata" version="3.7.2" release="16.1" arch="noarch" project="devel:languages:python" repository="openSUSE_Tumbleweed"/>
  <bdep name="python39-importlib-metadata" version="3.7.2" release="16.1" arch="noarch" project="devel:languages:python" repository="openSUSE_Tumbleweed"/>
  <bdep name="python38-importlib-metadata" version="3.7.2" release="16.1" arch="noarch" project="devel:languages:python" repository="openSUSE_Tumbleweed"/>

As an extra cleanup: since you have skip_python2, you could drop all the %ifpython2 sections