Overview

Request 891235 accepted

No description set

Dominique Leuenberger's avatar
27+%if %{python_version_nodots} < 38
28+BuildRequires:  %{python_module importlib-metadata}
29+%endif

I'm actually not sure this works as intended by you

  • the scheduler does not know python_version_nodots - that is only defined in the build env
  • even if it would: BuildRequires %{python_module FOO} would still expand to all python flavors.
dimstar_suse@zeus:~> osc buildinfo devel:languages:python python-SQLAlchemy openSUSE_Tumbleweed x86_64 | grep importlib-metadata
  <bdep name="python36-importlib-metadata" version="3.7.2" release="16.1" arch="noarch" project="devel:languages:python" repository="openSUSE_Tumbleweed"/>
  <bdep name="python39-importlib-metadata" version="3.7.2" release="16.1" arch="noarch" project="devel:languages:python" repository="openSUSE_Tumbleweed"/>
  <bdep name="python38-importlib-metadata" version="3.7.2" release="16.1" arch="noarch" project="devel:languages:python" repository="openSUSE_Tumbleweed"/>

As an extra cleanup: since you have skip_python2, you could drop all the %ifpython2 sections


Request History
Markéta Machová's avatar

mcalabkova created request


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Dominique Leuenberger's avatar

dimstar accepted review


Dominique Leuenberger's avatar

dimstar_suse set openSUSE:Factory:Staging:A as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:A"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked "openSUSE:Factory:Staging:A"


Saul Goodman's avatar

licensedigger accepted review

ok


Dominique Leuenberger's avatar

dimstar_suse accepted review

Staging Project openSUSE:Factory:Staging:A got accepted.


Dominique Leuenberger's avatar

dimstar_suse approved review

Staging Project openSUSE:Factory:Staging:A got accepted.


Dominique Leuenberger's avatar

dimstar_suse accepted request

Staging Project openSUSE:Factory:Staging:A got accepted.

openSUSE Build Service is sponsored by