Overview
aAutoEnable looks wrong
@factory-maintainer: please reopen, I can't.
> osc request reopen -m "reviewers don't know sed" 911094 HTTP Error 403: Forbidden post_request_no_permission No permission to change request 911094 state
Not knowing sed is one thing - but sending golfed code is another. Even after looking at what 'a' does, I wonder if instead of appending "AutoEnable=false" to "#AutoEnable=false\n", whether this should actually be replacing "#AutoEnable=false" by "AutoEnable=true". Because that would make sense.
I like the original file to stay as unchanged as possible to be able to easily diff it against the default file and only get additions. It's a matter of taste, certainly, and I could also have just patched it. The idea originally was that with the "echo ... >> main.conf" I do not have to maintain the patch. This plan failed badly.
If anyone wants a different solution, feel free to submtirequest it, I have quit maintaining bluez already anyway and am just handling the remaining bug reports.
Request History
seife created request
fix bluez-auto-enable-devices subpackage (boo#1177845)
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
RBrownSUSE set openSUSE:Factory:Staging:I as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:I"
RBrownSUSE accepted review
Picked "openSUSE:Factory:Staging:I"
jengelh accepted review
RBrownSUSE accepted review
Staging Project openSUSE:Factory:Staging:I got accepted.
RBrownSUSE approved review
Staging Project openSUSE:Factory:Staging:I got accepted.
RBrownSUSE accepted request
Staging Project openSUSE:Factory:Staging:I got accepted.
does not build
It builds against openSUSE:Factory but not against Base:System which has e.g. newer glibc.
Unignored: returned to active backlog.