Overview
Request 920149 superseded
1. Add plymouth-watermark-config.patch: Add two-step watermark theme config support, make the plymouth-branding easy to work (bsc#1189613). 2.Add plymouth-set-default-theme-suse-branding.patch: set plymouth's default theme to openSUSE/SUSE branding assigned style to avoid screen mass(bsc#1189613). 3. Update plymouth.spec: Rearrange plymouth sub packages dependencies to avoid installation failures due to a race installation state which will leading theme display fault(1189613).
- Created by qzhao
- In state superseded
- Supersedes 917855
- Superseded by 953317
-
Open review for
factory-staging
%posttrans
337-%{?regenerate_initrd_posttrans}
338+plymouth-set-default-theme -r
339+if [ $? -eq 0 ]; then
340+ plymouth-set-default-theme -R
341+fi
Does posttrans even get that parameter filled? I don't think it does, only pre, preun, post and postun do
I see no parameter.
Right...there is $?,not $1
Which makes me wonder why it's not just plymouth-set-default-theme -r && plymouth-set-default-theme -R
Hi:
This is a constructive suggestion, thank you for the idea.
Hi Dimstar @dimstar: Is there any exception？I saw you sent to evaluation staging project many times. Thank you.
it breaks openSUSE-branding build (apparently, needed some testing) - which is why I moved it to the backlog and to a different staging
Ok, I will look into it, and I will update you tomorrow.
Does there have any other problems?
Hi Dimstar:
Yesterday，a lot of factory package could not be built. I am try to find the reason that time. and glad to see the current result.
Do you mean the following error: [ 61s] plymouth-branding-openSUSE-84.87.20200106-5.10.noarch.rpm: directories not owned by a package:
[ 61s] plymouth-branding-openSUSE-84.87.20200106-5.10.noarch.rpm: directories not owned by a package:
[ 61s] - /usr/share/plymouth
[ 61s] - /usr/share/plymouth/themes
[ 61s] - /usr/share/plymouth/themes/spinner
These package does not belong to plymouth-branding-openSUSE, it's belong to plymouth-theme-spinner.
and I am in the weekly meeting now, after which I will look in this issue.
Thank you for the notice!
Requires: libpng16-16 Requires: libudev1
and others look very wrong. Not only will they need manual updating every time their version changes, it would have to take multiple distro versions and stagings into account. They should also be effectively no-ops.
Hi Dimstar:
fixes is in:
1, https://build.opensuse.org/request/show/920149
2, https://github.com/openSUSE/branding/pull/128
3, https://build.opensuse.org/request/show/920146
please review. and pickup "3" after "2", otherwise "3" could not build.
Thank you!
Request History
qzhao created request
1. Add plymouth-watermark-config.patch: Add two-step watermark theme config support, make the plymouth-branding easy to work (bsc#1189613). 2.Add plymouth-set-default-theme-suse-branding.patch: set plymouth's default theme to openSUSE/SUSE branding assigned style to avoid screen mass(bsc#1189613). 3. Update plymouth.spec: Rearrange plymouth sub packages dependencies to avoid installation failures due to a race installation state which will leading theme display fault(1189613).
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
dimstar_suse set openSUSE:Factory:Staging:I as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:I"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:I"
dimstar accepted review
dimstar declined review
Requires: libpng16-16
Requires: libudev1
and others look very wrong. Not only will they need manual updating every time their version changes, it would have to take multiple distro versions and stagings into account. They should also be effectively no-ops.
dimstar declined request
Requires: libpng16-16
Requires: libudev1
and others look very wrong. Not only will they need manual updating every time their version changes, it would have to take multiple distro versions and stagings into account. They should also be effectively no-ops.
dimstar_suse reopened request
Reopened via staging workflow.
dimstar_suse added factory-staging as a reviewer
Being evaluated by group "factory-staging"
dimstar_suse accepted review
Unstaged from project "openSUSE:Factory:Staging:I"
dimstar_suse declined request
Declined via staging workflow.
dirkmueller superseded request
superseded by 953317
