Overview
Request 922190 superseded
- update to rpm-4.17.0
- Created by mlschroe
- In state superseded
- Supersedes 921970
- Superseded by 923520
- Open review for openSUSE:Factory:Staging:C
There are multiple KDE-based packages failing the translations file list, like e.g
https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:C/kcodecs/standard/x86_64
The package seems not to do anything strange, which seems to imply rpm having a bug now
[ 50s] File must begin with "/": lang(ar) [ 50s] File must begin with "/": lang(as) [ 50s] File must begin with "/": lang(be) [ 50s] File must begin with "/": lang(be@latin) [ 50s] File must begin with "/": lang(bg) [ 50s] File must begin with "/": lang(bn) [ 50s] File must begin with "/": lang(bn_IN) [ 50s] File must begin with "/": lang(ca) [ 50s] File must begin with "/": lang(ca@valencia)
The generated list done by %find_lang used to be correct until rpm 4.16
Yeah, I messed up the find-lang-qt-qm patch. Now fixed.
kernel-source and patch fail with something like:
[ 20s] + exec rpmbuild -ba --define '_srcdefattr (-,root,root)' --nosignature --define '_build_create_debug 1' --define 'disturl obs://build.opensuse.org/openSUSE:Factory:Staging:C/standard/91b3d45bbab895a92073d6d4221734cb-kernel-source' /home/abuild/rpmbuild/SOURCES/kernel-source.spec [ 21s] error: /home/abuild/rpmbuild/SOURCES/kernel-source.spec: line 130: %verbose: unexpected argument [ 21s] 2< (%verbose)
in patch, the construct used is: make %{?_smp_mflags} %{verbose:V=1}; which seems no longer to be supported after the changes done.
TBF, %{verbose:V=1} is just garbage. Either you wanted %{?verbose:V=1}, or you wanted %{verbose}.
sure - I wasn't trying to imply rpm is at fault - so far I was only going for some 'patterns' in the failures.
for patch: sr#922152
Note that %{?verbose:V=1} also does not work. %verbose no longer allows an argument and is always defined.
You can use %[%verbose ? "V=1" : ""]
ah - works, but does not what it expected of it.
Since what version of rpm is %[%verbose ? "V=1" : ""] supported?
%[] aka expression expansion is supported since rpm-4.16. rpm-4.17 changed %verbose to take no argument and return 0/1 depending on the verbose setting. I noted to Panu (rpm upstream) that the %verbose change is somewhat risky, but he did it nevertheless in order to make all macros work the same.
I can't seem to find a way that works both in old rpms and in rpm-4.17...
nope: in rpm 4.16, verbose was not a variable, but a function. What you propose results in:
%verbose: argument expected
Should I add a patch that allows an optional argument for %verbose? I can also try to push that into upstream.
Some syntax that works with older and new rpm versions would be really great. So far the go-to solution was simply to strip usage of %verbose
systemd-rpm-macros fails on this construct:
Source0: macros.systemd
…
%{?load:%{S:0}}
Error in the log:
[ 56s] error: line 34: Unknown tag: /home/abuild/rpmbuild/SOURCES/macros.systemd i.e. load is ignored
Request History
mlschroe created request
- update to rpm-4.17.0
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
dimstar_suse set openSUSE:Factory:Staging:C as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:C"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:C"
licensedigger accepted review
The legal review is accepted preliminary. The package may require actions later on.
dimstar accepted review
superseded by 923520
[ 40s] error: /home/abuild/rpmbuild/SOURCES/gnu-compilers-hpc.spec: line 76: Too many levels of recursion in macro expansion. It is likely caused by recursive macro declaration.https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:C/gnu-compilers-hpc:gnu-hpc/standard/x86_64
Packaging glitch in suse-hpc's macros.hpc file. %__elflib_exclude_path does not exist anymore.
A possible fix is to change
global tmp %__elflib_exclude_pathtoglobal tmp %?__elflib_exclude_path. Or just do away with the definition.https://github.com/openSUSE/hpc/pull/7