Overview

Request 922217 accepted

- Work around rpmlint complaining about /var/log/journal shipped with setgid bit
This setgid bit has been already reviewed in the past and wasn't a
concern. However we want the mode/ownership adjusted by tmpfiles and
avoid the duplication of these info in rpm.
- Don't ghost own any directories created dynamically by tmpfiles
Again rpmlint complains but it doesn't seem to make sense to try to
track all paths (including theirs perms, ownerships...) created
dynamically. And 'rpm -V' is likely to report issues later with
these paths anyway.
This effectively partially reverts the two previous commits.

- Make sure the build process won't create /var/log/journal
- /var/log/journal/remote is owned by systemd-journal-remote

- systemd.spec: fix a bunch of rpmlint errors/warnings

- Drop systemd-logger
This sub package was introduced in order to configure persistent
journal and also to make sure that another syslog provider (such as
rsyslog) couldn't be installed at the same time: each syslog
provider conflicts with each others.
However this mechanism didn't work since uninstalling systemd-logger
wasn't magically turning off persistent logging because
/var/log/journal is likely to be populated hence not removed.
Moreover using a subpackage to configure the mode of journald was
overkill and the usual ways (main conf file or drop-ins) should be
preferred.

- Import commit 7a5801342fe2f53e5c2a8578d6db132c0eca2d97
8d65ec4a66 test: wc is needed by test/units/testsuite-50.sh

Loading...

Dominique Leuenberger's avatar

[ 341s] systemd-mini.x86_64: E: permissions-directory-setuid-bit (Badness: 10000) /var/log/journal is packaged with setuid/setgid bits (02755)

[ 341s] systemd-mini.x86_64: E: permissions-missing-postin (Badness: 100) missing %set_permissions /var/log/journal in %post

[  341s] systemd-mini.x86_64: E: dir-or-file-in-run /run/log
[  341s] systemd-mini.x86_64: E: dir-or-file-in-run /run/systemd
[  341s] systemd-mini.x86_64: E: dir-or-file-in-run /run/systemd/ask-password
[  341s] systemd-mini.x86_64: E: dir-or-file-in-run /run/systemd/machines
[  341s] systemd-mini.x86_64: E: dir-or-file-in-run /run/systemd/seats
[  341s] systemd-mini.x86_64: E: dir-or-file-in-run /run/systemd/sessions
[  341s] systemd-mini.x86_64: E: dir-or-file-in-run /run/systemd/shutdown
[  341s] systemd-mini.x86_64: E: dir-or-file-in-run /run/systemd/users

(run being all tmpfs, there is generally no reason to own/ghost them)

Request History
Franck Bui's avatar

fbui created request

- Work around rpmlint complaining about /var/log/journal shipped with setgid bit
This setgid bit has been already reviewed in the past and wasn't a
concern. However we want the mode/ownership adjusted by tmpfiles and
avoid the duplication of these info in rpm.
- Don't ghost own any directories created dynamically by tmpfiles
Again rpmlint complains but it doesn't seem to make sense to try to
track all paths (including theirs perms, ownerships...) created
dynamically. And 'rpm -V' is likely to report issues later with
these paths anyway.
This effectively partially reverts the two previous commits.

- Make sure the build process won't create /var/log/journal
- /var/log/journal/remote is owned by systemd-journal-remote

- systemd.spec: fix a bunch of rpmlint errors/warnings

- Drop systemd-logger
This sub package was introduced in order to configure persistent
journal and also to make sure that another syslog provider (such as
rsyslog) couldn't be installed at the same time: each syslog
provider conflicts with each others.
However this mechanism didn't work since uninstalling systemd-logger
wasn't magically turning off persistent logging because
/var/log/journal is likely to be populated hence not removed.
Moreover using a subpackage to configure the mode of journald was
overkill and the usual ways (main conf file or drop-ins) should be
preferred.

- Import commit 7a5801342fe2f53e5c2a8578d6db132c0eca2d97
8d65ec4a66 test: wc is needed by test/units/testsuite-50.sh


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Dominique Leuenberger's avatar

dimstar_suse set openSUSE:Factory:Staging:L as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:L"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked "openSUSE:Factory:Staging:L"


Saul Goodman's avatar

licensedigger accepted review

The legal review is accepted preliminary. The package may require actions later on.


Dominique Leuenberger's avatar

dimstar accepted review


Dominique Leuenberger's avatar

dimstar_suse added factory-staging as a reviewer

Being evaluated by group "factory-staging"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Unstaged from project "openSUSE:Factory:Staging:L"


Dominique Leuenberger's avatar

dimstar_suse set openSUSE:Factory:Staging:D as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:D"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked "openSUSE:Factory:Staging:D"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Staging Project openSUSE:Factory:Staging:D got accepted.


Dominique Leuenberger's avatar

dimstar_suse approved review

Staging Project openSUSE:Factory:Staging:D got accepted.


Dominique Leuenberger's avatar

dimstar_suse accepted request

Staging Project openSUSE:Factory:Staging:D got accepted.

openSUSE Build Service is sponsored by