Request History
simotek created request
licensedigger accepted review
ok
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
dimstar_suse set openSUSE:Factory:Staging:H as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:H"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:H"
dimstar accepted review
dimstar_suse added factory-staging as a reviewer
Being evaluated by group "factory-staging"
dimstar_suse accepted review
Unstaged from project "openSUSE:Factory:Staging:H"
dimstar_suse set openSUSE:Factory:Staging:E as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:E"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:E"
dimstar_suse accepted review
Staging Project openSUSE:Factory:Staging:E got accepted.
dimstar_suse approved review
Staging Project openSUSE:Factory:Staging:E got accepted.
dimstar_suse accepted request
Staging Project openSUSE:Factory:Staging:E got accepted.
A bit flabbergasted, but this change provoked
https://openqa.opensuse.org/tests/2016082#step/installation_overview/1
(removed the SR from H, rebuild ISO, rerun test -> passed)
22+%if 0%{?is_opensuse} 23 Requires: (grub2-branding-openSUSE if branding-openSUSE) 24+%else 25+%if 0%{?sle_version} 26+Requires: (grub2-branding-SLE if branding-SLE) 27+%endif 28+%endifIMHO, this could be all written without the if / else / if /endif / endif:
Simply do:
branding-SLE only exists on SLE, so it's usually not installed and this grub2-branding-SLE won't be required. Same logic for -openSUSE